Move tooltips out of skin.xml into source code
Bug #691864 reported by
jus
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Mixxx |
Fix Released
|
Wishlist
|
RJ Skerry-Ryan |
Bug Description
Tooltips should move out of the skins.xml into the source for various reasons
- to support ongoing mixxx-i18n efforts
- to provide a coherent user experience for all skins
- to eliminate a source of error for skin designers
Current tooltips are maybe a little to extensive so the content could use an overhaul too.
Also we should find a way to differentiate between "regular" tooltips and library tooltips as suggested here: https:/
Related branches
lp:~mixxxdevelopers/mixxx/1.11-skins
(Merged)
Changed in mixxx: | |
status: | New → Confirmed |
tags: | added: i18n |
tags: | added: tooltips |
Changed in mixxx: | |
milestone: | none → 1.11.0 |
Changed in mixxx: | |
assignee: | nobody → RJ Ryan (rryan) |
Changed in mixxx: | |
status: | Confirmed → Fix Committed |
Changed in mixxx: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
I agree that the tooltips shouldn't be in the skin.xml. Were you thinking we would automatically figure out the tooltip to display based on the connections? We could also switch to an ID system that works like this:
Deprecate the <Tooltip> section. Allow widget tags to take a tooltip="" attribute.
<Visual tooltip= "waveform- display" >
</Visual>
In the code, there will be a tooltips file that maps the tooltip IDs to their text. This way, we can submit the tooltip text for translations. If a skin designer would like to provide a custom tooltip or override a Mixxx default one, they can make a tooltips.xml to stick in their skin folder. It could look like this:
<tooltips> display" language= "en">Custom text for waveform tooltip</tooltip> display" language= "fr">.. .</tooltip>
<tooltip id="waveform-
<tooltip id="waveform-
</tooltips>
This should be discouraged since the skin designer will have to provide translations for their tooltips, but it will still allow them to make custom tooltips, while using the Mixxx provided ones by default. What do you think?