BPM tap changes pitch slider instead of base value

[RAFFI TEA]

I've played with the BPM tap button recently and think it needs improvement.

Using the BPM tap changes the *pitch slider* and not the base value in the library. This is not practical for me because most people use this feature to correct an incorrect computed BPM.

Also, if a track has a doubled BPM value (e.g., 180 BPM), there's no possibility to set the value to 90 BPM using the BPM tap. The BPM tap is limited by the +-10% pitch range. In this case, you can either use the track preferences to half the value or the editable track table view. Nevertheless, the BPM tap looks "strange" to me.

[jus (jus)]

I think there is some misunderstanding here.
The BPM tap button in the GUI is only supposed to alter the playback speed while performing ( aka changing pitch). This is the same behaviour you`ll get when hitting the keyboard keys Q and U. The range is limited by the settings for Pitch/rate slider range (max 90%).

The BPM tapping option to alter the base value is in the property editor ( right click on track in library) under the Track BPM tab. There is a double/half option too.

[Sean M. Pappalardo (pegasus-renegadetech)]

Agree with jus. Marking invalid. Perhaps we need to change the name of one of these functions to prevent such misunderstandings.

[RAFFI TEA (raffitea)]

Ah, ok. Renaming would be useful. BPM tap works different Traktor that's why I was surprised.

Anyway, I ask myself for what our BPM tap is useful? I would never use it for beat matching. We have the pitch sliders for that. Sorry for being a bit critical here.

[RJ Skerry-Ryan (rryan)]

It's kind of a quaint feature... its fun to tap the beat and listen to the playing song track it, but I'm not sure it's useful for DJing. I think the only reason it is this way is because that's how it was originally written to be by the previous development teams.

I also have never really seen a BPM-tapper that works this way. If you tap to the BPM, what should happen though? The track's BPM should be adjusted? In that case the waveform beat marks will shift as you tap and the track will be changed in the database.

What happens if the track is currently playing at a faster or slower rate than normal? Should we adjust the tapped-BPM by that scale factor? i.e. the deck is playing twice as fast as normal, you tap out the beat as you hear it, but the beat is being played back at a rate that is 2x, so should I divide the tapped BPM by 2 to adjust for the listener's perception

[Swiftb0y (swiftb0y)]

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/5700