Hide MenuBar with a KeyStroke

[Irwin J. Céspedes B]

Make possible to hide the menubar using only a keystroke, as SpeedCruch does. More details here: http://www.mixxx.org/forums/viewtopic.php?f=1&t=1726

[mutil (mutil)]

Here is a patch to toggle menu visibility with a menu option and a shortcut.
Can someone confirm if it's working as expected on mac and windows?

[jus (jus)]

I think we should respect the OS`s Interface Guidelines and common behaviors.

* On MacOS X, the menubar hides if an application goes fullscreen. Moving the mouse on top of the application window temporarily displays the menubar again. This is what Mixxx currently does.
Hiding the applications menubar in non-fullscreen mode is a no-no. OSX should be excluded by this patch.
* On Windows, afaik you can disable the menubar in fullscreen as well as non-fullscreen mode for various applications. Holding the ALT Key temporarily displays the menubar again. This eliminates the need to have the annoying popup message.
* On Linux, what is the usual behavior here?

F10 shortcut is taken, the [AutoDJ] controls are already assigned to F9-F12 function keys.

[mutil (mutil)]

Ignore my patch. Even on linux won't work well, as it disables all actions of the menu when it's hidden.
This is because shortcuts are assigned to actions binded to the menu and not to the main window, and Qt disables them if the widget is not active.

Jus, from what you describe, OSX doesn't need such thing (Windows too, maybe).
On Linux, this is hiding the menu independently of whether you are in fullscreen or not, so it's convenient to have this option for smaller screens.
But it's way more hassle than I thought, considering the ifdefs and the issue I described above.

[ronso0 (ronso0)]

two attempts to fix this in different ways:

Support hiding menubar and add menubarbutton
https://github.com/mixxxdj/mixxx/pull/3189

allow to hide the menu bar with [Controls],show_menubar
https://github.com/mixxxdj/mixxx/pull/3184

[Swiftb0y (swiftb0y)]

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/5556