legacy library importer does not set header_parsed flag

[Owen Williams]

When importing a v1.7 library, mixxx does not set the header_parsed flag, so that when a track is loaded in the player any info that the user might have changed (like the comment field) will get overwritten. By default, all tracks imported from an old library should have this flag set.

[Albert Santoni (gamegod)]

Good catch, thanks Owen!

Committed in 1.8, r2536.

Albert

On Thu, Sep 9, 2010 at 8:40 PM, Owen Williams <email address hidden> wrote:
>
> ** Patch added: "header_parsed.diff"
>   https://bugs.launchpad.net/bugs/634660/+attachment/1564172/+files/header_parsed.diff
>
> --
> legacy library importer does not set header_parsed flag
> https://bugs.launchpad.net/bugs/634660
> You received this bug notification because you are a member of Mixxx
> Development Team, which is subscribed to Mixxx.
>

[RJ Skerry-Ryan (rryan)]

I think the reason for this was that the old library didn't have some of the new metadata we track so this would force people's old stuff to be re-scanned. I think we should have some mechanism that people can re-read tags from a file. Maybe we could put a button in the track info dialog? They wouldn't be able to do it in bulk though.

[Albert Santoni (gamegod)]

On Thu, Sep 9, 2010 at 9:31 PM, RJ Ryan <email address hidden> wrote:
> I think the reason for this was that the old library didn't have some of
> the new metadata we track so this would force people's old stuff to be
> re-scanned. I think we should have some mechanism that people can re-
> read tags from a file. Maybe we could put a button in the track info
> dialog? They wouldn't be able to do it in bulk though.

That's what I was thinking, but our current code already handles this.
It reparses the metadata for every track and just sets the
genre/album/etc tags.

That would be a handy button in the track info dialog....

Albert

>
> --
> legacy library importer does not set header_parsed flag
> https://bugs.launchpad.net/bugs/634660
> You received this bug notification because you are a member of Mixxx
> Development Team, which is subscribed to Mixxx.
>

[Owen Williams (ywwg)]

The trouble is the code also updates the Comment field, which 99% of the time is useless in the file but I was using to store "tags" that I use to help search my library. With the new code, whenever I loaded a track my carefully-created tags would get blown away by the stupid comment field in the file. For me, anyway, it was a data loss bug. Maybe Mixxx just shouldn't the comment field based on the mp3 tags?

[RJ Skerry-Ryan (rryan)]

There was another bug that was causing even tracks with the header_parsed flag set to be re-parsed on load. This combined with the fix for this bug should prevent the data loss issue you mention.

[RJ Skerry-Ryan (rryan)]

The legacy update code doesn't update the comment field -- it only updates fields that are new that Mixxx wasn't able to read before 1.8.0. I think it probably seemed like the comment field was updated b/c of the bug I mentioned in #6.

[Swiftb0y (swiftb0y)]

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/5508