Fix jog control in trunk

Bug #632542 reported by Guy Martin
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mixxx
New
Undecided
Unassigned

Bug Description

The attached patch fix jog control.

It does two things.

First get rid of the division by 10. This is useless since the jogValue usually goes from -3 to 3 (depending on the midi device script). If it's divided by 10, then you cannot go reverse since the equation to get the final rate is rate += jogValue. So at best you can get 0.7 as the rate.

Second, it multiplies by two the JogValue if it's negative. This allow the scratching to feel more real since it compensate for the fact that the rate is 1 and you need to first go have a jogValue of -1 to get reverse direction.

It applies on trunk. It probably fixes 529945 as well but I haven't looked at the code in the 1.8 release.

Revision history for this message
Guy Martin (gmsoft) wrote :
Revision history for this message
Guy Martin (gmsoft) wrote :

Oops, the rate should only be multiplied by two if we are playing.

New patch fixes this.

Revision history for this message
Guy Martin (gmsoft) wrote :

Sorry for the spam, I forgot to remove the FIXME comment which is now invalid.

Revision history for this message
Albert Santoni (gamegod) wrote : Re: [Bug 632542] Re: Fix jog control in trunk

Committed in 1.8, r2535...

If we broke anything with this, we'll figure it out on Saturday....

Thanks!
Albert

On Thu, Sep 9, 2010 at 2:29 AM, RJ Ryan <email address hidden> wrote:
> *** This bug is a duplicate of bug 529945 ***
>    https://bugs.launchpad.net/bugs/529945
>
> ** This bug has been marked a duplicate of bug 529945
>   Jog wheel seeking much slower in in 1.8.0beta1 than 1.7.1
>  * You can subscribe to bug 529945 by following this link: https://bugs.launchpad.net/mixxx/+bug/529945/+subscribe
>
> --
> Fix jog control in trunk
> https://bugs.launchpad.net/bugs/632542
> You received this bug notification because you are a member of Mixxx
> Development Team, which is subscribed to Mixxx.
>

Revision history for this message
Swiftb0y (swiftb0y) wrote :

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/5505

lock status: Metadata changes locked and limited to project staff
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.