Wasted CPU time in wvumeter.cpp

Bug #632017 reported by jus on 2010-09-06
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mixxx
Medium
RJ Skerry-Ryan

Bug Description

Default_Falltime for peaks (VUmeter peaks for channel1/2 + master in the GUI) is defined in wvumeter.cpp (around line 27).
Timer updates way to often at 10 ms . If set to 80-100 ms, Mixxx need more then 10% less CPU (idle) here (trunk Mac OSX 10.5.8).
Falltime can be defined per skin in the corresponding skin.xml , but no skin actually use it (will fix that later on).
Changing the hardcoded default value might be a still necessary as fallback.

Related branches

jus (jus) on 2010-09-06
description: updated
jus (jus) on 2010-09-06
description: updated
RJ Skerry-Ryan (rryan) on 2010-09-07
Changed in mixxx:
importance: Undecided → Medium
RJ Skerry-Ryan (rryan) wrote :

It turns out that the timer was completely unnecessary and I've removed it from the 1.8 branch. This saves the 10ms timer across all 3 VU meters and causes a noticeable CPU usage drop for me as well.

Good eye Jus!

Changed in mixxx:
assignee: nobody → RJ Ryan (rryan)
milestone: none → 1.8.0
status: New → Fix Committed
RJ Skerry-Ryan (rryan) on 2010-10-05
Changed in mixxx:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers