Clicking through iTunes and Rythmbox playlists cause massive memory leaks

Bug #601188 reported by RAFFI TEA on 2010-07-02
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Mixxx
Undecided
Unassigned
1.8
Undecided
Owen Bullock

Bug Description

This bug can be reproduced on Windows and Linux, and probably on OSX, too.

I will use the new iTunes feature a lot in future and observed a massive memory leak. Whenever you click or open an iTunes play-list, Mixxx allocates new memory without freeing the memory from the previous iTunes play-list view. Also, if you return to previous viewed play-list, Mixxx allocated new memory.

To summarise, having some medium or large iTunes playlists you can run out of memory very quickly while clicking through. You can observe the memory leak by simply watching the task manager. Attached you find the valgrind output.

RAFFI TEA (raffitea) wrote :
RJ Skerry-Ryan (rryan) wrote :

Thanks Tobias, not surprised!

Changed in mixxx:
status: New → Confirmed
milestone: none → 1.8.0
Changed in mixxx:
milestone: 1.8.0 → none
Owen Bullock (owen-bullock) wrote :

I've made a small patch for this - both for itunes and rythymbox. TrackInfoObjects won't be created unnecessarily now.

(This is the first patch i've submitted, so please let me know if i've done anything wrong or unconventional... )

RAFFI TEA (raffitea) wrote :

Good work. I can confirm for rythymbox that there are no memory leaks anymore.

jus (jus) wrote :

Works for iTunes on OSX too. No more leaks.

RAFFI TEA (raffitea) wrote :

I experience also a performance boost. It's a lot faster to use these features now!!!

Albert Santoni (gamegod) wrote :

Thanks for the patch Owen, and thanks for testing it Jus and Tobias.

I've reviewed it and committed it in the 1.8 branch, r2520.

Albert

Changed in mixxx:
status: Confirmed → Fix Committed
RJ Skerry-Ryan (rryan) on 2010-10-05
Changed in mixxx:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers