scons doesnt detect missing libfaad library

Bug #593077 reported by Owen Bullock on 2010-06-12
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mixxx
Low
Owen Bullock

Bug Description

I'm compiling trunk on Debian Linux. I didn't have the libfaad-dev package installed, theres a check for this in the SConscript file, but its broken and doesnt warn you. Instead it attempts to compile and soundsourcem4a.cpp fails due to a missing header.

Looks like this area of the SConscript has been worked on recently, to provide compatility with versions 2.6 and 2.7 of libfaad. I think as a result of this, the basic check for the library has got broken.

Patch attached, compilation tested successfully against both libfaad 2.6 and 2.7 versions

Related branches

Owen Bullock (owen-bullock) wrote :
Changed in mixxx:
milestone: none → 1.8.0
RJ Skerry-Ryan (rryan) wrote :

Thanks for the patch Owen, I committed it to our 1.8.x release branch.

Changed in mixxx:
status: New → Fix Committed
importance: Undecided → Low
assignee: nobody → Owen Bullock (owen-bullock)
RJ Skerry-Ryan (rryan) wrote :

Added you to the contributor list as Owen Bullock. Please let me know if you'd like to be credited under a different name :).

Albert Santoni (gamegod) wrote :

This broke my build on Ubuntu 8.10. In my case, the solution is probably to fix our SConscript so it doesn't run configure checks before running targets. In other words, I don't want "scons makeubuntu" to check for ANY dependencies, because it ends up building inside a different (chrooted pbuilder) environment.

RJ Skerry-Ryan (rryan) on 2010-10-05
Changed in mixxx:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers