Flags missing on SConscript for 32bit compilation under 64bit architecture

Bug #546632 reported by Bruno Buccolo on 2010-03-25
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Mixxx
Medium
Bruno Buccolo

Bug Description

Under Mac OSX 10.6 (Snow Leopard) I had to force a 32bit compilation (with the force32=1 flag), since 64bit wouldn't work.
It all went well until the linking step yielded an error (not of required architecture), then I saw that the linking step had no flags telling g++ that the files were compiled for 32bit. All it takes is to append -m32 flag on the linking step of the building process.

Also noticed that on the Agner Fog's ASMLIB part of the SConscript, to choose whether to use a 32bit or 64bit version of the library (linux and macosx are affected), SConscript looks at the architecture. Which would be wrong if I were on a 64bit architecture but had the force 32bit flag on.

I'm submitting a patch along.

Thanks!

Committed in r2395 of trunk. Thanks for catching that and the fix!

Changed in mixxx:
importance: Undecided → Medium
milestone: none → 1.8.0
status: New → Fix Committed
assignee: nobody → Bruno Buccolo (bruno-buccolo)
RJ Skerry-Ryan (rryan) on 2010-10-05
Changed in mixxx:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers