ASSERT on loading track to paused but moving deck

Bug #533431 reported by Sean M. Pappalardo on 2010-03-06
12
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mixxx
High
Unassigned

Bug Description

This occurs in trunk r2358.

Steps to reproduce:
1) Remove the "- 1.0f" in ratecontrol.cpp line 363 "rate = scratchFactor - 1.0f + jogFactor + wheelFactor/10.;"
2) Build and start Mixxx
3) Load a track.
Observe Fatal abort: Fatal: []: ASSERT: "unscaled_samples_needed >= 0" in file src/engine/enginebufferscalelinear.cpp, line 140

description: updated
summary: - Crash on MP3 load with MIDI controller
+ ASSERT on MP3 load with MIDI controller

This looks to me like some kind of bizarre race condition with rate. It might also be related to the low latency/lerp bug.

Whoops, this was a result of having changed something (removed the +1.0f on scratchFactor) in ratecontrol.cpp in my working copy such that rate was being set to a value <1. But that shouldn't cause a problem, right? The track would just go really slow.

summary: - ASSERT on MP3 load with MIDI controller
+ ASSERT on loading track to playing deck
summary: - ASSERT on loading track to playing deck
+ ASSERT on loading track to moving deck (0< rate <1)
description: updated
summary: - ASSERT on loading track to moving deck (0< rate <1)
+ ASSERT on loading track to moving deck (not in play status though)
summary: - ASSERT on loading track to moving deck (not in play status though)
+ ASSERT on loading track to paused but moving deck
RJ Skerry-Ryan (rryan) wrote :

This is related to the issue we were seeing with the same assert happening when holding scratch still. For some reason when rate is 0, the EB is still processing samples. This should not be.

RJ Skerry-Ryan (rryan) on 2010-06-18
Changed in mixxx:
status: New → Confirmed
RJ Skerry-Ryan (rryan) wrote :

I think this is gone now..

I think so too.

Changed in mixxx:
status: Confirmed → Fix Committed
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Bug attachments