Not all FLAC metadata loads.

[RJ Skerry-Ryan]

From the forums post on 1.8.0 beta 1. FLAC files only load Artist, Album, Title. Now that we have all these fancy library columns we should make sure the various soundsources load the tags when possible.

[RJ Skerry-Ryan (rryan)]

I looked at libsndfile and I didn't see defines for getting more elaborate metadata. It may be that we have to bring a FLAC specific library for this.

[Phillip Whelan (pwhelan)]

  libFLAC is able to support the full range of metadata. This would
inevitably add another dependency. The download page for libflac is
at: http://flac.sourceforge.net/download.html. Someone with windows
could see if it has a useable binary of libflac for windows. They also
have various files for Mac OS X.

  Another choice would be to roll our own metadata decoder. The format
is not that hard to handle, but this could lead to maintenance
nightmares. Mixxx has enough code as it is without handling audio
metadata and decoding.

  Our last choice would be to improve the metadata support in
libsndfile. In the short run it would mean carrying around another
dependency, but in the same way we do with soundtouch. In the long
run, if the patches are accepted upstream, we could get rid of it.

That's my $.02. Enjoy! And keep up the good work.

[RJ Skerry-Ryan (rryan)]

Another option is to use taglib for all of our metadata reading.

http://developer.kde.org/~wheeler/taglib.html

<http://developer.kde.org/~wheeler/taglib.html>It supports every format we
use and claims to be 6 times faster than libid3tag -- so it would help us
with MP3 reading as well. Also, it's used by VLC, Traktor, Amarok, and
Last.fm so it's popular and well supported cross platform.

On Sun, Feb 21, 2010 at 4:45 PM, pwhelan <email address hidden> wrote:

> libFLAC is able to support the full range of metadata. This would
> inevitably add another dependency. The download page for libflac is
> at: http://flac.sourceforge.net/download.html. Someone with windows
> could see if it has a useable binary of libflac for windows. They also
> have various files for Mac OS X.
>
> Another choice would be to roll our own metadata decoder. The format
> is not that hard to handle, but this could lead to maintenance
> nightmares. Mixxx has enough code as it is without handling audio
> metadata and decoding.
>
> Our last choice would be to improve the metadata support in
> libsndfile. In the short run it would mean carrying around another
> dependency, but in the same way we do with soundtouch. In the long
> run, if the patches are accepted upstream, we could get rid of it.
>
> That's my $.02. Enjoy! And keep up the good work.
>
> --
> Not all FLAC metadata loads.
> https://bugs.launchpad.net/bugs/517913
> You received this bug notification because you are a direct subscriber
> of the bug.
>

[Phillip Whelan (pwhelan)]

+1 to taglib

[RJ Skerry-Ryan (rryan)]

I don't think we can fix this for 1.8.0 because we are under a feature freeze and adding taglib falls more under the realm of a feature than a bug. I think we should wait for 1.8.1 to tackle this. Albert?

[Albert Santoni (gamegod)]

Yeah, there's no simple way to fix this for 1.8. We should defer it to
a later release.

On Sun, Feb 28, 2010 at 9:32 PM, RJ Ryan <email address hidden> wrote:
> I don't think we can fix this for 1.8.0 because we are under a feature
> freeze and adding taglib falls more under the realm of a feature than a
> bug. I think we should wait for 1.8.1 to tackle this. Albert?
>
> --
> Not all FLAC metadata loads.
> https://bugs.launchpad.net/bugs/517913
> You received this bug notification because you are a member of Mixxx
> Development Team, which is subscribed to Mixxx.
>

[RJ Skerry-Ryan (rryan)]

Setting the milestone to none is a sure way for us to forget about this :)
Can we have something like a 'Future' milestone that is like "Stuff we need
to do but aren't right now." ? I've been setting anything that slips from
1.8.0 to the 1.9.0 milestone so that we can filter that later.

On Mon, Mar 1, 2010 at 1:57 PM, Pegasus <email address hidden> wrote:

> ** Changed in: mixxx
> Milestone: 1.8.0 => None
>
> --
> Not all FLAC metadata loads.
> https://bugs.launchpad.net/bugs/517913
> You received this bug notification because you are a direct subscriber
> of the bug.
>

[William Good (bkgood)]

The most recent revision (2411 currently) of my attached branch adds metadata support for FLAC, at least what is supported. Vorbis comments (aka flac tags) is a rather free-form system of simple key=value pairs, and xiph has some standard keys they recommend. The only two mixxx uses it doesn't have in the standard are comment and BPM, but I added them anyway (there's nothing to stop a tagger from adding the fields).

[Swiftb0y (swiftb0y)]

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/5307