Location of iTunes XML file is hard coded

Bug #513517 reported by RAFFI TEA
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mixxx
Fix Released
Medium
RJ Skerry-Ryan

Bug Description

This bug has already been reported to mixxx-devel mailing list! I put it here for the sake of completeness.

================BUG DESCRIPTION===================
The hard-coded iTunes XML path in Mixxx assumes an English version of Windows.
Attached you find patches for itunesfeature.cpp, itunestrackmodel.cpp and itunestrackmodel.h.

I removed the corresponding DEFINES and wrote a static method ITunesTrackModel::getiTunesMusicPath() which reads "HKEY_CURRENT_USER\Software\Microsoft\Windows\CurrentVersion\Explorer\User
Shell Folders" from registry to obtain the path of the music folder.

Kind regards

Tobias

Revision history for this message
RAFFI TEA (raffitea) wrote :
Revision history for this message
RJ Skerry-Ryan (rryan) wrote :

Thanks Tobias -- I'll get to this soon.

Changed in mixxx:
importance: Undecided → Medium
status: New → Confirmed
assignee: nobody → RJ Ryan (rryan)
milestone: none → 1.7.3
milestone: 1.7.3 → 1.8.0
Revision history for this message
RJ Skerry-Ryan (rryan) wrote :

Hey Tobias,

I added your code to lookup the library path using QSettings to our trunk in revision 2295. Could you please try it out to make sure that what I committed works as desired?

Thanks,
RJ

Changed in mixxx:
status: Confirmed → Fix Committed
Revision history for this message
RAFFI TEA (raffitea) wrote : Re: [Bug 513517] Re: Location of iTunes XML file is hard coded

Hey RJ,

Thanks for the commit. I just tested revision 2295 and it did not work.

Reason:
Your changed my
 #elif defined(__WINDOWS__)
to
 #elif defined(__WIN__)

I claim you looked at Albert's original DEFINES. However, __WIN__ is
nowhere defined in SConscript, but __WNDOWS__ :-)

Am 01.02.2010 10:40, schrieb RJ Ryan:
> Hey Tobias,
>
> I added your code to lookup the library path using QSettings to our
> trunk in revision 2295. Could you please try it out to make sure that
> what I committed works as desired?
>
> Thanks,
> RJ
>
> ** Changed in: mixxx
> Status: Confirmed => Fix Committed
>

Revision history for this message
RJ Skerry-Ryan (rryan) wrote :

Oops -- fixed. :)

RJ Skerry-Ryan (rryan)
Changed in mixxx:
status: Fix Committed → Fix Released
Revision history for this message
Swiftb0y (swiftb0y) wrote :

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/5295

lock status: Metadata changes locked and limited to project staff
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.