Location of iTunes XML file is hard coded

Bug #513517 reported by RAFFI TEA on 2010-01-27
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mixxx
Medium
RJ Skerry-Ryan

Bug Description

This bug has already been reported to mixxx-devel mailing list! I put it here for the sake of completeness.

================BUG DESCRIPTION===================
The hard-coded iTunes XML path in Mixxx assumes an English version of Windows.
Attached you find patches for itunesfeature.cpp, itunestrackmodel.cpp and itunestrackmodel.h.

I removed the corresponding DEFINES and wrote a static method ITunesTrackModel::getiTunesMusicPath() which reads "HKEY_CURRENT_USER\Software\Microsoft\Windows\CurrentVersion\Explorer\User
Shell Folders" from registry to obtain the path of the music folder.

Kind regards

Tobias

RAFFI TEA (raffitea) wrote :
RJ Skerry-Ryan (rryan) wrote :

Thanks Tobias -- I'll get to this soon.

Changed in mixxx:
importance: Undecided → Medium
status: New → Confirmed
assignee: nobody → RJ Ryan (rryan)
milestone: none → 1.7.3
milestone: 1.7.3 → 1.8.0
RJ Skerry-Ryan (rryan) wrote :

Hey Tobias,

I added your code to lookup the library path using QSettings to our trunk in revision 2295. Could you please try it out to make sure that what I committed works as desired?

Thanks,
RJ

Changed in mixxx:
status: Confirmed → Fix Committed

Hey RJ,

Thanks for the commit. I just tested revision 2295 and it did not work.

Reason:
Your changed my
 #elif defined(__WINDOWS__)
to
 #elif defined(__WIN__)

I claim you looked at Albert's original DEFINES. However, __WIN__ is
nowhere defined in SConscript, but __WNDOWS__ :-)

Am 01.02.2010 10:40, schrieb RJ Ryan:
> Hey Tobias,
>
> I added your code to lookup the library path using QSettings to our
> trunk in revision 2295. Could you please try it out to make sure that
> what I committed works as desired?
>
> Thanks,
> RJ
>
> ** Changed in: mixxx
> Status: Confirmed => Fix Committed
>

RJ Skerry-Ryan (rryan) wrote :

Oops -- fixed. :)

RJ Skerry-Ryan (rryan) on 2010-10-05
Changed in mixxx:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers