Searching for single-quote string fails in features_sqlite
Bug #500217 reported by
rfcmedia
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Mixxx |
Fix Released
|
Medium
|
RJ Skerry-Ryan | ||
Bug Description
Probably a quoting issue in SQL, but if you search your library from a song like "Let's Go" with a single-
Steps to reproduce.
1. Go to the search bar while looking at your library
2. Type "Let's" without the double quotes.
Expected behavior: either nothing shows up, or some songs show up.
Observed behavior: as soon as you type the apostrophe, the column headers (title, album, etc) disappear
And after that you cannot search or view your library anymore.
I think this is pretty critical, since many of songs have single quotes in them.
Related branches
lp:~mixxxdevelopers/mixxx/features_sqlite
- Albert Santoni: Approve
-
Diff: 4444 lines (+710/-654)117 files modifiedmixxx/src/analyser.h (+5/-5)
mixxx/src/analyserbpm.cpp (+5/-5)
mixxx/src/analyserbpm.h (+14/-14)
mixxx/src/analyserqueue.cpp (+14/-9)
mixxx/src/analyserqueue.h (+14/-14)
mixxx/src/analyserwaveform.cpp (+11/-11)
mixxx/src/analyserwaveform.h (+8/-8)
mixxx/src/analyserwavesummary.cpp (+2/-2)
mixxx/src/analyserwavesummary.h (+7/-7)
mixxx/src/bpm/bpmreceiver.h (+0/-47)
mixxx/src/cachingreader.cpp (+5/-5)
mixxx/src/cachingreader.h (+7/-7)
mixxx/src/dlgautodj.cpp (+7/-7)
mixxx/src/dlgautodj.h (+3/-2)
mixxx/src/dlgprepare.cpp (+16/-15)
mixxx/src/dlgprepare.h (+4/-4)
mixxx/src/dlgtrackinfo.cpp (+3/-3)
mixxx/src/dlgtrackinfo.h (+4/-3)
mixxx/src/encodermp3.cpp (+30/-30)
mixxx/src/encodermp3.h (+3/-3)
mixxx/src/encodervorbis.cpp (+8/-8)
mixxx/src/encodervorbis.h (+3/-3)
mixxx/src/engine/cuecontrol.cpp (+6/-6)
mixxx/src/engine/cuecontrol.h (+4/-4)
mixxx/src/engine/enginebuffer.cpp (+8/-8)
mixxx/src/engine/enginebuffer.h (+6/-6)
mixxx/src/engine/engineclipping.cpp (+1/-1)
mixxx/src/engine/engineshoutcast.cpp (+2/-2)
mixxx/src/engine/engineshoutcast.h (+2/-2)
mixxx/src/library/abstractxmltrackmodel.cpp (+7/-12)
mixxx/src/library/abstractxmltrackmodel.h (+3/-5)
mixxx/src/library/autodjfeature.cpp (+4/-4)
mixxx/src/library/basesqltablemodel.cpp (+1/-1)
mixxx/src/library/basesqltablemodel.h (+0/-1)
mixxx/src/library/browsefeature.cpp (+4/-4)
mixxx/src/library/browsetablemodel.cpp (+3/-3)
mixxx/src/library/browsetablemodel.h (+2/-2)
mixxx/src/library/cratetablemodel.cpp (+1/-1)
mixxx/src/library/cratetablemodel.h (+1/-1)
mixxx/src/library/dao/cue.h (+1/-2)
mixxx/src/library/dao/cuedao.h (+2/-2)
mixxx/src/library/dao/playlistdao.h (+0/-1)
mixxx/src/library/dao/trackdao.cpp (+99/-16)
mixxx/src/library/dao/trackdao.h (+20/-6)
mixxx/src/library/itunesplaylistmodel.cpp (+4/-4)
mixxx/src/library/itunesplaylistmodel.h (+1/-2)
mixxx/src/library/itunestrackmodel.cpp (+6/-5)
mixxx/src/library/itunestrackmodel.h (+2/-3)
mixxx/src/library/legacylibraryimporter.cpp (+9/-3)
mixxx/src/library/library.cpp (+12/-13)
mixxx/src/library/library.h (+6/-6)
mixxx/src/library/libraryfeature.h (+4/-3)
mixxx/src/library/librarytablemodel.cpp (+1/-1)
mixxx/src/library/librarytablemodel.h (+1/-1)
mixxx/src/library/missingtablemodel.cpp (+1/-1)
mixxx/src/library/missingtablemodel.h (+1/-1)
mixxx/src/library/playlisttablemodel.cpp (+1/-1)
mixxx/src/library/playlisttablemodel.h (+1/-1)
mixxx/src/library/preparefeature.cpp (+4/-4)
mixxx/src/library/promotracksfeature.cpp (+10/-6)
mixxx/src/library/promotracksfeature.h (+3/-3)
mixxx/src/library/promotrackswebview.cpp (+9/-7)
mixxx/src/library/promotrackswebview.h (+5/-5)
mixxx/src/library/proxytrackmodel.cpp (+1/-1)
mixxx/src/library/proxytrackmodel.h (+1/-1)
mixxx/src/library/rhythmboxplaylistmodel.cpp (+2/-2)
mixxx/src/library/rhythmboxplaylistmodel.h (+1/-2)
mixxx/src/library/rhythmboxtrackmodel.cpp (+3/-2)
mixxx/src/library/rhythmboxtrackmodel.h (+1/-2)
mixxx/src/library/trackcollection.h (+0/-1)
mixxx/src/library/trackmodel.h (+2/-3)
mixxx/src/mixxx.cpp (+30/-27)
mixxx/src/mixxx.h (+3/-3)
mixxx/src/mixxxview.cpp (+55/-55)
mixxx/src/mixxxview.h (+7/-7)
mixxx/src/player.cpp (+15/-15)
mixxx/src/player.h (+7/-7)
mixxx/src/playerinfo.cpp (+6/-6)
mixxx/src/playerinfo.h (+5/-5)
mixxx/src/soundsourcemp3.h (+0/-1)
mixxx/src/soundsourceoggvorbis.h (+0/-3)
mixxx/src/soundsourceproxy.cpp (+15/-16)
mixxx/src/soundsourceproxy.h (+4/-4)
mixxx/src/soundsourcesndfile.h (+1/-2)
mixxx/src/test/analyserbpmtest.cpp (+2/-2)
mixxx/src/test/analyserwaveformtest.cpp (+2/-2)
mixxx/src/test/analyserwavesummarytest.cpp (+2/-2)
mixxx/src/trackinfoobject.cpp (+6/-2)
mixxx/src/trackinfoobject.h (+12/-4)
mixxx/src/waveform/glwaveformrenderer.cpp (+26/-26)
mixxx/src/waveform/glwaveformrenderer.h (+4/-5)
mixxx/src/waveform/renderobject.h (+3/-3)
mixxx/src/waveform/waveformrenderbackground.cpp (+3/-3)
mixxx/src/waveform/waveformrenderbackground.h (+1/-2)
mixxx/src/waveform/waveformrenderbeat.cpp (+2/-2)
mixxx/src/waveform/waveformrenderbeat.h (+2/-3)
mixxx/src/waveform/waveformrenderer.cpp (+3/-3)
mixxx/src/waveform/waveformrenderer.h (+4/-4)
mixxx/src/waveform/waveformrendermark.cpp (+1/-1)
mixxx/src/waveform/waveformrendermark.h (+2/-3)
mixxx/src/waveform/waveformrendermarkrange.cpp (+1/-1)
mixxx/src/waveform/waveformrendermarkrange.h (+2/-3)
mixxx/src/waveform/waveformrendersignal.cpp (+1/-1)
mixxx/src/waveform/waveformrendersignal.h (+2/-3)
mixxx/src/waveform/waveformrendersignalpixmap.cpp (+8/-8)
mixxx/src/waveform/waveformrendersignalpixmap.h (+2/-3)
mixxx/src/waveform/waveformrendersignaltiles.cpp (+1/-1)
mixxx/src/waveform/waveformrendersignaltiles.h (+2/-3)
mixxx/src/widget/wglwaveformviewer.h (+0/-1)
mixxx/src/widget/wlibrarytableview.h (+3/-3)
mixxx/src/widget/woverview.cpp (+6/-1)
mixxx/src/widget/woverview.h (+3/-2)
mixxx/src/widget/wvisualsimple.cpp (+3/-7)
mixxx/src/widget/wvisualsimple.h (+1/-3)
mixxx/src/widget/wwaveformviewer.h (+2/-3)
mixxx/src/wtracktableview.cpp (+4/-4)
mixxx/src/wtracktableview.h (+4/-3)
Revision history for this message
| RJ Skerry-Ryan (rryan) wrote | #1 |
| Changed in mixxx: | |
| importance: | Undecided → Medium |
| status: | New → Confirmed |
| assignee: | nobody → RJ Ryan (rryan) |
| milestone: | none → 1.8.0 |
Revision history for this message
| RJ Skerry-Ryan (rryan) wrote | #2 |
| Changed in mixxx: | |
| status: | Confirmed → Fix Committed |
| Changed in mixxx: | |
| status: | Fix Committed → Fix Released |
Revision history for this message
| Swiftb0y (swiftb0y) wrote | #3 |
| lock status: | Metadata changes locked and limited to project staff |
To post a comment you must log in.
Nice catch! I'll fix this soon.