Mixxx allows loading video files from iTunes into player which cause crash

Bug #496945 reported by jus on 2009-12-15
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mixxx
Medium
RJ Skerry-Ryan

Bug Description

OSX 10.6.2 / iTunes 9.0.2 / features_sqlite branch

Mixxx does not check if a file from iTunes playlist is readable audio file. All available files from your iTunes library are selectable.

So you can load (music)-videos into Mixxx` player which will cause a crash.
Tested with *.m4v and *.mov files.

jus (jus) wrote :
RJ Skerry-Ryan (rryan) wrote :

Thanks jus,

I just added a fix to trunk (we just moved features_sqlite to trunk). Please let me know if this fixes it. It should not show m4v's, mov's (or any other file Mixxx cannot play) in the iTunes library anymore, nor should it show any playlist that does not have any audio files in it.

RJ

Changed in mixxx:
status: New → Fix Committed
importance: Undecided → Medium
assignee: nobody → RJ Ryan (rryan)
milestone: none → 1.8.0
jus (jus) wrote :

Hmmm, can`t build from trunk cause of scons error "Did not find Porttime development header,exiting!".

This error is new, have not changed my config. Will try later again.

ironstorm (ironstorm-gmail) wrote :

Hi, Jus... it looks like portmidi is now required to build Mixxx in trunk, I don't know what version is needed but I'm guessing the libportmidi-dev package version in Karmic would be sufficient.

jus (jus) wrote :

I ended up compiling Portmidi for OSX from source http://sourceforge.net/projects/portmedia/files/portmidi/199/portmidi-src-199.zip/download. Now all dependencies are fine.

But could not compile r2241 with mp4 support, scons terminated because of error:

src/soundsourcem4a.cpp:169: error: 'MP4Free' was not declared in this scope
src/soundsourcem4a.cpp:175: error: 'MP4Free' was not declared in this scope
src/soundsourcem4a.cpp:181: error: 'MP4Free' was not declared in this scope
src/m4a/mp4-mixxx.cpp: At global scope:
src/m4a/mp4-mixxx.cpp:439: warning: 'int mp4_seek(input_plugin_data*, double)' defined but not used
src/m4a/mp4-mixxx.cpp:529: warning: 'int mp4_duration(input_plugin_data*)' defined but not used
scons: *** [osx_build/soundsourcem4a.o] Error 1
scons: building terminated because of errors.

jus (jus) wrote :

Compiled r2241 without mp4 support.

Could not see any difference in Mixxx iTunes view. Is the missing mp4 support the reason?
Still *.m4v ,*.mp4 and *.mov files are visible and causing a crash when loaded in player.

iTunes playlists containing mp3 audio files doesn`t show up at all.

jus (jus) wrote :

Hmmm, i may bring this bug back to life..

Testing Mixxx 1.8beta2 r2444 and by accident i scrolled to the iTunes movie folder in Mixxx`library.
I have a bunch of *.mp4 movie file in there.
First Mixxx stalled and by clicking on a random file in the folder Mixxx crashed.

Debug: [Main]: Track -1 set dirty
Debug: [Main]: Getting SoundSource plugin object for "mp4"
Debug: [Main]: SSM4A::ParseHeader : "/Users/me/Music/iTunes/iTunes Music/Movies/filename.mp4" could not be opened using the MP4 decoder.
Debug: [Main]: TrackInfoObject: emitting bpmUpdated signal!
QEventDispatcherUNIXPrivate(): Unable to create thread pipe: Too many open files
Fatal: []: QEventDispatcherUNIXPrivate(): Can not continue without a thread pipe

Program received signal SIGABRT, Aborted.

RJ Skerry-Ryan (rryan) on 2010-10-05
Changed in mixxx:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers