Enhancements for .desktop file
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Mixxx |
Fix Released
|
Undecided
|
jus |
Bug Description
I noticed some problems in Mixxx's .desktop file while making the Mandriva package. The following patch changes these things:
- the Encoding setting is removed (it's obsolescent currently, I think). You may want not to include this change, I'm not sure if it's correct for all distros or only MDV.
- a GenericName is added (some desktops expect this).
The Icon is changed from 'mixxx-icon.png' to 'mixxx-icon'. This is correct as per current XDG standards (specifying an extension is incorrect), but requires another change: icons need to be installed as per the freedesktop.org icon theme, as they used to be in Mixxx 1.5 but no longer appear to be in 1.6 (to the /usr/share/
StartupNotify=true is specified.
The categories are amended to include Qt;
the empty GenericName[en_CA] field is removed, it doesn't seem to be doing anything useful.
Related branches
- Albert Santoni: Approve
-
Diff: 2300 lines (+792/-192)19 files modifiedmixxx/res/images/templates/skin_template_outline.svg (+154/-62)
mixxx/res/skins/Deere1280x1024-SXGA/skin.xml (+22/-2)
mixxx/res/skins/Deere1280x800-WXGA/skin.xml (+22/-2)
mixxx/res/skins/LateNight1280x1024-SXGA/skin.xml (+22/-2)
mixxx/res/skins/LateNight1280x800-WXGA/skin.xml (+22/-2)
mixxx/res/skins/LateNightBlues1280x1024-SXGA/skin.xml (+22/-2)
mixxx/res/skins/LateNightBlues1280x800-WXGA/skin.xml (+22/-2)
mixxx/res/skins/Outline1024x600-Netbook/skin.xml (+97/-22)
mixxx/res/skins/Outline1024x768-XGA/skin.xml (+97/-22)
mixxx/res/skins/Outline800x480-WVGA/skin.xml (+99/-24)
mixxx/res/skins/Phoney1600x1200-UXGA/skin.xml (+22/-2)
mixxx/res/skins/Phoney1680x1050-WSXGA/skin.xml (+22/-2)
mixxx/res/skins/PhoneyDark1600x1200-UXGA/skin.xml (+22/-2)
mixxx/res/skins/PhoneyDark1680x1050-WSXGA/skin.xml (+22/-2)
mixxx/res/skins/Shade1024x600-Netbook/skin.xml (+37/-16)
mixxx/res/skins/Shade1024x768-XGA/skin.xml (+37/-16)
mixxx/res/skins/ShadeDark1024x600-Netbook/skin.xml (+24/-4)
mixxx/res/skins/ShadeDark1024x768-XGA/skin.xml (+24/-4)
mixxx/src/skin/legacyskinparser.cpp (+3/-2)
Changed in mixxx: | |
status: | New → Fix Committed |
assignee: | nobody → jus (jus) |
Changed in mixxx: | |
status: | Fix Committed → Fix Released |
Better late then never... bazaar. launchpad. net/~jus/ mixxx/skins/ revision/ 2391
Adapted patch for 1.8 and pushed in http://