DEBUG ASSERT (2) in effects_refactoring branch

[Daniel Schürmann]

I see this as start up:

critical[Main] DEBUG ASSERT: "m_registeredEffects.contains(effectId)" in function virtual EffectManifestPointer BuiltInBackend::getManifest(const QString&) const at /home/daniel/workspace/i18n/src/effects/backends/builtin/builtinbackend.cpp:91

This happens if an configured effect is no longer enabled for some reasons.

[Be (be.ing)]

Please elaborate how to reproduce this.

[Daniel Schürmann (daschuer)]

I was able to reproduce it by de-installing an LV2 plugin. However this was nothing I have done in the first place. So I guess there must be something else wrong.

[Daniel Schürmann (daschuer)]

Got it. The issue is that EffectPresetManager::loadDefaultEffectPresets tries to create a preset for every file it finds in the directory. In case of an non existing effect, it has a preset with a null manifest, causing the assertion. This can be fixed by only looking up files for existing effecs.

[Be (be.ing)]

What is the solution? Log a warning instead of an assertion?

[Daniel Schürmann (daschuer)]

The issue is that all the sorrounding code is not aware of a failure.
This applies to the string for the backend in the same way.
There we must add some extra null checks and than we can finally remove the assertion.
I didn't not think we need a warning at all.

[Swiftb0y (swiftb0y)]

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/10582