Mixxx

wrong sized loops

Bug #1945238 reported by Owen Williams
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mixxx
Fix Committed
Medium
Daniel Schürmann
Mixxx 2.4.0

Bug Description

On a particular track, loop sizes create at the main cue point are messed up for some reason. A 1-beat loop is 2 beat. A 2-beat loop is 3. 8 beat loop? 9 beats. Sub-beat loops are ok. this doesn't seem to happen anywhere else in the track

Revision history for this message
Owen Williams (ywwg) wrote :
Revision history for this message
Be (be.ing) wrote :

Does this occur on the 2.3 branch, main branch, or both? If it is only on the main branch it is likely related to the recent Beats refactoring.

Potentially related: https://bugs.launchpad.net/mixxx/+bug/1942657

Revision history for this message
Owen Williams (ywwg) wrote :

main only, not 2.3. I'm guessing there is an edge-case of rounding up instead of down somewhere.

Revision history for this message
Owen Williams (ywwg) wrote :

(And this is a const beatgrid track)

Revision history for this message
Be (be.ing) wrote :

That would be a plausible explanation for both this and https://bugs.launchpad.net/mixxx/+bug/1942657

Uwe Klotz (uklotzde-deactivatedaccount)
Changed in mixxx:
milestone: none → 2.4.0
importance: Undecided → High
Revision history for this message
Owen Williams (ywwg) wrote :

This issue is caused by this commit: https://github.com/mixxxdj/mixxx/commit/95f7d36647a6df05c413d5f37f1ce878653a3ce0

Because Floating Point, sometimes the math is not perfect. In my case, the 4th beat is calculated as .001 past the 4th calculated beat, and therefore the ceiling call rounds up to the next whole beat. The previous fuzzy logic ensured that we would not do that.

Revision history for this message
Owen Williams (ywwg) wrote :

reverting the commit fixes the issue, I will file a PR

Changed in mixxx:
assignee: nobody → Owen Williams (ywwg)
importance: High → Medium
Revision history for this message
Daniel Schürmann (daschuer) wrote :

This fixes the root cause:
https://github.com/mixxxdj/mixxx/pull/4366

Changed in mixxx:
status: New → In Progress
assignee: Owen Williams (ywwg) → Daniel Schürmann (daschuer)
Be (be.ing)
Changed in mixxx:
status: In Progress → Fix Committed
Revision history for this message
Swiftb0y (swiftb0y) wrote :

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/10541

lock status: Metadata changes locked and limited to project staff
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.