Keylock is ignored after startup

Bug #1943180 reported by Sven Rahn
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fix Released

Bug Description

I am on 2.3.0-59-g8a93f365bc.

Steps to reproduce:

1. Enable keylock
2. Close Mixxxx
3. Open Mixxx
4. Load a track
5. Play the deck
6. Jog (by right click dragging on the waveform or with a controller mapping), and only jog "a little", not full speed

Expected: No tone change since keylock is enabled.
Actual outcome: The key changes.

The issue disappears when changing the tempo via the "rate" control or when turning keylock off and on again.

Revision history for this message
ronso0 (ronso0) wrote :

I'm currently working on a fix for different issue, though the are related I think.
EngineBuffer::processTrackLocked requests keylock from KeyControl, though, it's keylock var is not updated when KeyControl is initialized, only after first rate change (not jog/nudge).

Changed in mixxx:
importance: Undecided → Low
status: New → In Progress
assignee: nobody → ronso0 (ronso0)
milestone: none → 2.3.3
Revision history for this message
ronso0 (ronso0) wrote :
Changed in mixxx:
milestone: 2.3.3 → none
Revision history for this message
ronso0 (ronso0) wrote :

the PR linked above got a bit out of hands.

This is the one with the keylock fix only:

Changed in mixxx:
milestone: none → 2.3.3
status: In Progress → Fix Released
Revision history for this message
Swiftb0y (swiftb0y) wrote :

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:

lock status: Metadata changes locked and limited to project staff
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.