Sync: Tempo dip when silence a sync track

[Daniel Schürmann]

This was found during the review of https://github.com/mixxxdj/mixxx/pull/4156 which aims to fix the issue:

Instead of a jump, we now have the tempo dip stretched over some seconds.
This can be reproduced the best with two 440 Hz tracks and:

    Playing two tracks with sync enabled the second one silenced by the line fader
    Nudge the second track
    Bring the second track in
    Silence the first track.
    Now the nudging is reverted gradually. (Without this branch it was reverted immediately)
    This can be noted by listening the silenced track in headphone
    When you bring the track in, the phase adjustment is gone.

[Daniel Schürmann (daschuer)]

when I remove

    if (isMaster(mode)) {
        m_pBpmControl->resetSyncAdjustment();

from void SyncControl::setSyncMode(SyncMode mode) the issue is gone.

Unfortunately the issue is then shifted to the sync enable case because the leader adjustment is not reset when playing as single leader. The code is in place, but somehow bypassed. Hopefully you know already how to fix it right from the main code.

[ronso0 (ronso0)]

is/was there a PR fixing this?

[Owen Williams (ywwg)]

This is fixed by https://github.com/mixxxdj/mixxx/pull/4363

[Owen Williams (ywwg)]

(I think)

[Swiftb0y (swiftb0y)]

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/10489