Sync: Tempo dip when silence a sync track
Bug #1939103 reported by
Daniel Schürmann
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Mixxx |
New
|
Medium
|
Owen Williams |
Bug Description
This was found during the review of https:/
Instead of a jump, we now have the tempo dip stretched over some seconds.
This can be reproduced the best with two 440 Hz tracks and:
Playing two tracks with sync enabled the second one silenced by the line fader
Nudge the second track
Bring the second track in
Silence the first track.
Now the nudging is reverted gradually. (Without this branch it was reverted immediately)
This can be noted by listening the silenced track in headphone
When you bring the track in, the phase adjustment is gone.
Changed in mixxx: | |
assignee: | nobody → Owen Williams (ywwg) |
To post a comment you must log in.
when I remove
if (isMaster(mode)) {
m_pBpmControl- >resetSyncAdjus tment() ;
from void SyncControl: :setSyncMode( SyncMode mode) the issue is gone.
Unfortunately the issue is then shifted to the sync enable case because the leader adjustment is not reset when playing as single leader. The code is in place, but somehow bypassed. Hopefully you know already how to fix it right from the main code.