Windows display scaling factors 125% + 175% are not applied correctly

[mirh]

At least on Windows it's pretty awfully small.

[Daniel Schürmann (daschuer)]

There is work in progress to set an extra scale factor from the preferences https://github.com/mixxxdj/mixxx/pull/3960

In the meantime you can set the environment variable QT_SCALE_FACTOR
manually.

[Be (be.ing)]

Mixxx uses the OS's scaling setting. What is the problem?

[ronso0 (ronso0)]

A screenshot of a native windows app (Notepad?) would help us to compare the scaling.
Please post the entire screen with the app maximized.

[mirh (mirh)]

You are absolutely right. I just tested 150% and 200% scaling and they work.
On the other hand, 125% and 175% are the same exact size of 100% and 150% respectively (save for the menu bar and the font size of the vertical folder list)

I just tested QT_SCALE_FACTOR=1.25 though, and that didn't have problems.

[Be (be.ing)]

This is likely Qt trying to be too clever with rounding the scale factor...

[ronso0 (ronso0)]

maybe QT_SCALE_FACTOR_ROUNDING_POLICY
https://bugreports.qt.io/browse/QTBUG-53022

[mirh (mirh)]

You are spot on
https://bugreports.qt.io/browse/QTBUG-86344

EDIT: interestingly enough, while QT_SCALE_FACTOR_ROUNDING_POLICY=PassThrough managed to also do most of the trick, it neglected the size of the library fonts.

[Jan Holthuis (holthuis-jan)]

We could use https://doc.qt.io/qt-5/qt.html#HighDpiScaleFactorRoundingPolicy-enum if we switched to Qt 5.14.

[ronso0 (ronso0)]

isn't only Ubuntu requiring Qt 5.12? (in 2.3)
so #ifdef Qt <= 5.14 would fix it for Windows (macOS isn't affected IIRC)

@mirh
The library font can be set independently from the OS in Preferences > Library

I can't believe I can **EDIT** this comment..

[mirh (mirh)]

I'm saying that forcing the scale factor still had an overall marginally better looking experience than the rounding policy.

Also, it is my understanding from the linked commits above that all platforms should be affected.. It's just that probably nobody has high hidpi expectations on linux /s

[Be (be.ing)]

> if we switched to Qt 5.14

We are already using Qt 5.15.2 on Windows. It is only macOS where we are stuck with Qt 5.12.

[Be (be.ing)]

mirh, could you test setting the environment variable QT_SCALE_FACTOR_ROUNDING_POLICY=PassThrough before starting Mixxx from a command prompt? If this works well without odd looking artifacts we may consider setting the rounding policy to passthrough by default.
https://doc.qt.io/qt-5/qguiapplication.html#setHighDpiScaleFactorRoundingPolicy

[ronso0 (ronso0)]

> It is only macOS where we are stuck with Qt 5.12.

If we intend to fix this in a 2.3 point release it's not applicable to Ubuntu 20.04 builds because those are still using 5.12.8

[Be (be.ing)]

That only affects Ubuntu LTS users. Other Linux distros are not stuck on Qt 5.12.

[Jan Holthuis (holthuis-jan)]

I propose to add the fix inside a QT_VERSION_CHECK.

People using Ubuntu will have to live with the current scaling behavior, but it's actually a good thing. Stable distros are for users that don't want their system to change without a distro upgrade, so fixing the bug would be confusing and might break their workflows :D.

[ronso0 (ronso0)]

I can't turn on the CPU fan with spacebar anymore :D

[Be (be.ing)]

Yes, a QT_VERSION_CHECK is needed because Mixxx 2.3 still supports Qt 5.12.

[Jan Holthuis (holthuis-jan)]

> I can't turn on the CPU fan with spacebar anymore :D

Context: https://xkcd.com/1172/

[Daniel Schürmann (daschuer)]

https://github.com/mixxxdj/mixxx/pull/4161

[Swiftb0y (swiftb0y)]

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/10485