Crash (segfault) when using empty directory as resourcePath

[Michael]

Mixxx crashes when 'resourcePath' points to either an empty, or a non existing directory.
("mixxx" received signal SIGSEGV, Segmentation fault).

The 'Mixxx - Critical error' popup window appears correctly, stating that the skin directory is missing. After clicking 'OK' Mixxx tries to open, but crashes.
Maybe a better default behaviour would be to stop Mixxx when a critical error appears?

[Michael (ehmic)]

Here is the gdb output.

[Jan Holthuis (holthuis-jan)]

What Mixxx version does this affect? I cannot tell from the log (we should add an Info message).

Please copy the version (and git version string) from the about dialog.

[Michael (ehmic)]

Ah sorry, forgot to mention...

Version is: 2.3.0-8-gd3052f4fc5

[Uwe Klotz (uklotzde-deactivatedaccount)]

main terminates regularly without a crash after a bunch of warnings and debug assertions:

warning [Main] Failed to load default skin "LateNight"
critical [Main] DEBUG ASSERT: "m_pSkin != nullptr" in function DlgPrefInterface::DlgPrefInterface(QWidget*, std::shared_ptr<mixxx::ScreensaverManager>, std::shared_ptr<mixxx::skin::SkinLoader>, UserSettingsPointer) at ../src/preferences/dialog/dlgprefinterface.cpp:48

critical [Main] "Skin directory does not exist: /tmp/mixxx_empty_res/skins"
critical [Main] DEBUG ASSERT: "pSkin && pSkin->isValid()" in function mixxx::skin::SkinPointer mixxx::skin::SkinLoader::getConfiguredSkin() const at ../src/skin/skinloader.cpp:122

warning [Main] Failed to load default skin "LateNight"
critical [Main] DEBUG ASSERT: "pSkin != nullptr && pSkin->isValid()" in function QWidget* mixxx::skin::SkinLoader::loadConfiguredSkin(QWidget*, QSet<ControlObject*>*, mixxx::CoreServices*) at ../src/skin/skinloader.cpp:145

[Uwe Klotz (uklotzde-deactivatedaccount)]

2.3 crashes after an assertion:

Debug [Main]: =====================================
Debug [Main]: 0 ms stopping pending Library tasks
Critical [Main]: DEBUG ASSERT: "m_pScanner" in function void TrackCollectionManager::stopLibraryScan() at ../src/library/trackcollectionmanager.cpp:172

Thread 1 "mixxx" received signal SIGSEGV, Segmentation fault.

[Uwe Klotz (uklotzde-deactivatedaccount)]

Probably difficult to fix for 2.3 and not worth the effort.

[Daniel Schürmann (daschuer)]

https://github.com/mixxxdj/mixxx/pull/4575

[Swiftb0y (swiftb0y)]

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/10461