Track poperties dialog, musicbrains metadata is applied imediatly.

[Daniel Schürmann]

There is now a mismatch between the behavior of the two buttons in the track property dialog:

* Re-Import Metadata from file (wong capitalization btw.)
* Import Metadata from Musicbrains

the later is applied immediately to track while the later requires Apply

Both should be made persistent after Apply only.

The Musicbrais dialog itself has Apply and Cancel.
It would be nice to have an OK button as well.

Please note that this dialog is also called from the track context menu where the direct apply is expected.

[Michael (ehmic)]

If this is not too urgent I may address myself to this bug, as I'm currently working on Musicbrains stuff anyhow.

[Michael (ehmic)]

Had a closer look and I agree that an OK button makes sense in the the MB dialog.

But I'm not sure if it is senseful to change the behaviour of the MB Apply button and make the changes persistent after clicking the Apply button in the track properties instead.

Although it is called from the track property dialog of a single track, the MB feature has the option to go through all tracks in a certain directory (Buttons Previous and Next) in order to make changes to their tags (more like a standalone tagging tool). It would somehow feel strange to open the MB dialog via the first track's properties and then make also changes to, let's say 10 more tracks, click Apply (in MB dialog) each time to store the temporary changes, but make them persistent only when the Apply Button in the properties dialog of the last selected track is clicked.

The suggested behaviour would make sense without (or with suppressed) Previous and Next buttons.

Or am I missing/confusing something here?

[Daniel Schürmann (daschuer)]

Sounds reasonable. What do you suggest?

It is the question if we treat the music brains dialog independent or as a sub dialog of a specific track properties dialog.

The pro solution would be to integrate the music brains dialog as a widget into the track properties dialog ... mmm a lot of work.

Ideas?

[Swiftb0y (swiftb0y)]

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/10443