add platform-specific default.qss
Bug #1923876 reported by
ronso0
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Mixxx |
New
|
Wishlist
|
ronso0 |
Bug Description
default-mac.qss
default-linux.qss
default-windows.qss
Right now there's a lot of redundancy across skins in style sheets for most Mixxx menus like WTrackMenu and #MainMenu menubar; and for complete theming styles for the Track Poperties window, tag fetcher and Preferences will be added, too.
To ease maintenance of all that let's move the common proven styles to a central place.
Changed in mixxx: | |
status: | New → Confirmed |
Changed in mixxx: | |
status: | In Progress → New |
To post a comment you must log in.
that was easy, implemented here /github. com/ronso0/ mixxx/tree/ platform- default- styles
https:/
put on hold for now (2.3) because
* for custom skins make the main menubar hard to use because _any_ property set for #MainMenu would remove the OS palette, thus there would be no selection highlight and no checkmark icons
* Mixxx skin's menu styles make use of '#LibraryContainer QMenu...' (shortcut to select QMenus in WLibrarySidebar , WLibrary, WSearchlineEdit, ...) and that doesn't pass the qsscheck pre-commit hook (yet) because #LibraryContainer is not set anywhere in c++ and is probably not used in custom skins, thus custom skins would have inconsistent, broken menus