add platform-specific default.qss

Bug #1923876 reported by ronso0
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mixxx
New
Wishlist
ronso0

Bug Description

default-mac.qss
default-linux.qss
default-windows.qss

Right now there's a lot of redundancy across skins in style sheets for most Mixxx menus like WTrackMenu and #MainMenu menubar; and for complete theming styles for the Track Poperties window, tag fetcher and Preferences will be added, too.

To ease maintenance of all that let's move the common proven styles to a central place.

Tags: skin
Changed in mixxx:
status: New → Confirmed
Revision history for this message
ronso0 (ronso0) wrote :

that was easy, implemented here
https://github.com/ronso0/mixxx/tree/platform-default-styles

put on hold for now (2.3) because
* for custom skins make the main menubar hard to use because _any_ property set for #MainMenu would remove the OS palette, thus there would be no selection highlight and no checkmark icons
* Mixxx skin's menu styles make use of '#LibraryContainer QMenu...' (shortcut to select QMenus in WLibrarySidebar , WLibrary, WSearchlineEdit, ...) and that doesn't pass the qsscheck pre-commit hook (yet) because #LibraryContainer is not set anywhere in c++ and is probably not used in custom skins, thus custom skins would have inconsistent, broken menus

Changed in mixxx:
assignee: nobody → ronso0 (ronso0)
status: Confirmed → In Progress
ronso0 (ronso0)
Changed in mixxx:
status: In Progress → New
Revision history for this message
Daniel Schürmann (daschuer) wrote :

Can this one be closed?

Revision history for this message
ronso0 (ronso0) wrote :

not really.
recently I introduced default-menu-styles-[windows, linux].qss, though those are not parsed by the skinloader like default.qss but just set in the Style node of skin.xml via src-win and src-linux.
for mac we still need custom stylesheets to work around some strange click/release behaviour (skin setting buttons in Deere and Tango).
That said, it would still be convenient to have the requested platform styles parsed without having to specify them in each skin.xml

Revision history for this message
Swiftb0y (swiftb0y) wrote :

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/10393

lock status: Metadata changes locked and limited to project staff
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.