CTRL+P doesn't start Preferences

[OsZ]

With Mixxx 2.3.0-beta (build r8110 - confirmed with git-2.3-2021-04-07) the Preferences Window doesn't open anymore using CTRL+P

Expected: CTRL+P should open the Preferences Window

compiled from source using EndevourOS (Arch based)
cmake v 3.20.0
gcc v 10.2.0

[ronso0 (ronso0)]

maybe a system shortcut is catching the signal and it's not registered in Mixxx?

what happens in other apps or on the desktop when you press Ctrl+P ?

[OsZ (toszlanyi)]

CTRL+P is the system wide print command

In previous versions of Mixxx 2.3 beta as well as on current main branch (2.4 alpha) it is available and opens Preferences.

While comparing the versions I started them with option --locale en and then Ctrl+P is working. I further tried:

mixxx --locale fr | Ctrl+P is working
mixxx --locale nl | Ctrl+P is working
mixxx --locale de | Ctrl+P is NOT working and the shortcut is also not visible inside the pull down menu.

[jus (jus)]

I noticed your screenshot does not show the shortcuts from the Mixxx translation files for the German locale (de)
Are they overridden by your system?
According to your systems setting, are you using EN keyboard layout as input source by chance?

In the German Mixxx locale ``Ctrl`` is translated with ``Strg``, ``Shift`` with ``Umschalt`` etc.
(see my screenshot from a recent Windows installation of Mixxx).

[OsZ (toszlanyi)]

@jus - i see where you coming from - but the words translation in my Mixxx installation is German, except the Ctrl+...

Is there a special flag to compile with or dependencies I need? My system locale is set to German

$ locale
LANG=de_DE.UTF-8
LC_CTYPE="de_DE.UTF-8"
LC_NUMERIC=de_DE.UTF-8
LC_TIME=de_DE.UTF-8
LC_COLLATE="de_DE.UTF-8"
LC_MONETARY=de_DE.UTF-8
LC_MESSAGES="de_DE.UTF-8"
LC_PAPER=de_DE.UTF-8
LC_NAME=de_DE.UTF-8
LC_ADDRESS=de_DE.UTF-8
LC_TELEPHONE=de_DE.UTF-8
LC_MEASUREMENT=de_DE.UTF-8
LC_IDENTIFICATION=de_DE.UTF-8
LC_ALL=

[jus (jus)]

This is weird, never noticed that strange behavior. But I can confirm similar issues with macOS.

CTRL+P is no issue in macOS, because it is overridden by the system wide preferences shortcut ⌘, (Unicode: U+2318).

But CTRL+F (search focus) does not work either, if the language is set to German.

$ locale
LANG="de_DE.UTF-8"
LC_COLLATE="de_DE.UTF-8"
LC_CTYPE="de_DE.UTF-8"
LC_MESSAGES="de_DE.UTF-8"
LC_MONETARY="de_DE.UTF-8"
LC_NUMERIC="de_DE.UTF-8"
LC_TIME="de_D

I can reproduce that back to Mixxx 2.2.1, Mixxx 2.1.8 being the last working version.

Moreover, if running

./mixxx --developer

You can see one press of CTRL+F is fired multiple time
debug [Main] keyboard press: "Ctrl+F"
debug [Main] keyboard press: "Ctrl+F"
debug [Main] keyboard press: "Ctrl+F"
debug [Main] keyboard press: "Ctrl+F"

This needs further investigation.

tested with 2.4.0-alpha-pre (build main r7832), and 2.3.0-beta (build 2.3 r8120)

[jus (jus)]

The issue happened before elsewhere, after translating shortcut strings.
We might miss a QT dependency for translating qt base itself.
See [1], [2] and [5].

As last resort, we might just disable translations for keyboard shortcut strings in the translation template.

[1] https://github.com/void-linux/void-packages/issues/14415
[2] https://github.com/helloSystem/ISO/issues/9
[3] https://archlinux.org/packages/extra/any/qt5-translations/

[OsZ (toszlanyi)]

Wicked!

... installed `qt5-translations` and the German translated Mixxx GUI now shows "Strg+P" and shortcut works as expected.

So the dependency to `qt5-translations` will solve it. Is that a Mixxx or Arch package issue?

Thanks a lot for your help!

[ronso0 (ronso0)]

a web search reveals that qt5-translations is an Arch package only.
so it's not an actual build dependency..
maybe just tell the package maintainer about it.

[OsZ (toszlanyi)]

I left a comment there - Jan Holzhaus is the maintainer ;)

[jus (jus)]

This bug does NOT apply to Windows, there we pack the needed ``qtbase_`` catalog [1] correctly [5].
The catalog is in the qttranslations-everywhere-src-5.xx.x.zip submodule, part of a default qt installation.

We need to add this to the build requirements for the other supported platforms too.

[1] https://doc.qt.io/qt-5/internationalization.html#locating-qt-translations
[2] https://github.com/mixxxdj/mixxx/blob/2.3/CMakeLists.txt#L1416

[Uwe Klotz (uklotzde-deactivatedaccount)]

Just noticed that Fedora is also affected. Will be fixed with the next builds.

https://github.com/rpmfusion/mixxx/commit/29c7a3d98b4f55824f20617adc9cff043192e3c5

[ronso0 (ronso0)]

so, this is now fixed on Arch an Fedora?

[OsZ (toszlanyi)]

For Arch nothing changed yet. Anyhow, I think people could find my comment and install the package manually in case they have issues.

https://aur.archlinux.org/packages/mixxx_beta-git/#comment-800966

[Uwe Klotz (uklotzde-deactivatedaccount)]

Fix for Fedora.

[Jan Holthuis (holthuis-jan)]

Oh, didn't notice that comment. I'll add the missing dependency.

[Jan Holthuis (holthuis-jan)]

Fixed in commit https://aur.archlinux.org/cgit/aur.git/commit/?h=mixxx_beta-git&id=829a0785f865eb19b6264e688b1a616c66470df1.

[Jan Holthuis (holthuis-jan)]

mixxx-git fixed here: https://aur.archlinux.org/cgit/aur.git/commit/PKGBUILD?h=mixxx-git&id=710cbfe9d85ffa4101d3edae77a69baa9167561f

[OsZ (toszlanyi)]

Does it still need a fix for macOS? See comment #5 by @jus:
https://bugs.launchpad.net/mixxx/+bug/1922961/comments/5

[Swiftb0y (swiftb0y)]

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/10389