cleanup macOS Catalina + Big Sur Sandboxing access permission dialog

[Foss-4]

Current Dialog:

Due to Mac Sandboxing, we need your permission to access this file:

After clicking OK, you will see a file picker. To give Mixxx permission, you must select " to proceed. If you do not want to grant Mixxx acces click Cancel on the file picker. We're sory for this inconvenience.

To abort this action, press Cancel on the file dialog.

No | Yes

Thoughts
- is this about general access to the harddrive and the tracks? If yes, there is no need to reference a specific file, so this should be rephrased.
- if it is indeed about a specific file, that file should be shown
- OK and Cancel are not the options given in this dialog. So either the buttons need to be correctly named or the text needs to be re-written
- don't be sorry for this inconvenience - this is macOS defaults and every app accessing files shows such a dialog. By now users are familiar with this. Why should anybody be sorry for better privacy protection for users?

[Be (be.ing)]

When do you see this specific dialog?

[Foss-4 (foss-4)]

Saw it on each mac once after installing 2.3 I think. I am not sure what triggers this but would assume this is related to the fact mixxx is now notarized and maybe Apple applies different rights management to notarized software.

It is a bit hard to say as before copying the mixxx database to this specific mac I saw the dialog on, mixxx on that mac was stuck in that dead end dialog where scanning the covers resulted in a crash for both selecting yes or no.

Looking at system preferences > security > privacy > files and folders Mixxx is listed with permission to access both Downloads and Documents folder (the latter where music files are stored on macs). Mixxx is not listed in Full Harddrive Access so I assume those two permissions where the ones Mixxx is asking for with this dialog.

It is also interesting that this seems to be a custom dialog, but I would expect macOS has standard dialogs that should be used for asking for file access permission.

[Foss-4 (foss-4)]

Actually seeing this dialog on every launch on this 10.15.7 mac. Clicked yes, clicked no, doesn't matter, dialog keeps showing on launch.

[Daniel Schürmann (daschuer)]

Can you file a second bug for the 10.15.7 issue? This is a critical issue, because it makes Mixxx useless on this version of MacOs.

This bug can be closed soon. Just propose an improved text and we will integrate it. Here or as a GiHub pull request. The test is defined here:
https://github.com/mixxxdj/mixxx/blob/c8f148eafcb868e4a88ebfce65c5e9b08724e912/src/util/sandbox.cpp#L110

[Foss-4 (foss-4)]

There are various problems with this dialog outlined in the initial report and without info about those rephasing is not possible.

Besides those question the suggested file picker does not show for me when clicking "Yes" and even when clicking yes on next relaunch the dialog re-appears. So besides rephrasing, this dialog does not seem to do what it claims to do.

Have no insight, but aren't those macOS permission dialogs default dialogs that are created by xcode? https://developer.apple.com/documentation/security/app_sandbox

[Uwe Klotz (uklotzde-deactivatedaccount)]

Next report about non-working migration of application data, maybe related:

https://mixxx.discourse.group/t/macbook-pro-runs-very-hot-when-using-mixxx/22382

Let's just drop macOS support if no developer steps in ;) Seriously, these issues cannot be resolved without an Apple device at hand.

[Foss-4 (foss-4)]

Update on this specific error, which I think should be kept separate from the two recent discourse reports:

* https://mixxx.discourse.group/t/macbook-pro-runs-very-hot-when-using-mixxx/22382/
* https://mixxx.discourse.group/t/trouble-with-mixxx-on-mac-book-pro/22408

My setup: use mixxx actively on mac 1, clone music folder and mixxx library + prefs folder to mac 2 and use mixxx there as music player with tags, loops etc from mac 1.

Results in:
a) Mixxx on mac 2 thinks the music files are located at /Users/UsernameMac1/MusicFolder which of course is incorrect
b) sandbox dialog is shown
To fix this:
* Mixxx > Preferences > Library > Relink (process may never finish or get stuck)
* restart Mixxx
* rescan Library

Results in:
a) Library working again as expected
b) Sandbox warning no longer showing

The issues around wording and functionality of the sandbox dialog remain however. I am not sure if for my specific edge case, the sandbox dialog is expected or unexpected.

Also I do not know if when shown for correct cases it does what it is supposed to do or not.

[Daniel Schürmann (daschuer)]

The fist part is here https://github.com/mixxxdj/mixxx/pull/4015

[Uwe Klotz (uklotzde-deactivatedaccount)]

The remaining fixes are supposed to be done for 2.4.0 to prevent string changes and missing translations of these important instructions.

[Daniel Schürmann (daschuer)]

The string fixes are here:
https://github.com/mixxxdj/mixxx/pull/4018

[Swiftb0y (swiftb0y)]

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/10373