control object creation order broken in main branch: cos created by skin not available to controller scripts

[Owen Williams]

My traktor s3 script stopped loading correctly in main. I see this:

Warning [Controller] ControlDoublePrivate::getControl returning NULL for ( "[Channel1]" , "end_of_track" )
Warning [Controller] ControllerScriptHandlerBase: "Uncaught exception at line 1729 in file file:///home/owen/src/github/mixxx/res/controllers/Traktor-Kontrol-S3-hid-scripts.js.\n\nException:\n Error: script tried to connect to ControlObject ([Channel1], end_of_track) which is non-existent."

Other times the control it barfs on is Master / maximize_library.

Both of these control objects do exist, but are not created until the skin parsing code comes across them and then creates them on the fly. It looks like something happened in the startup ordering to break this. I am doing a git bisect to see if I can locate the change.

[Be (be.ing)]

Likely a regression from https://github.com/mixxxdj/mixxx/pull/3446

[Owen Williams (ywwg)]

I don't think that pull request is necessarily wrong. maximize_library is referenced in main code, but isn't ever created there. The main menubar could own it, for instance. There may be other GUI actions we'd like to make available and should have explicit COs, like show_mixer / show_vinylcontrol / show_coverart

[ronso0 (ronso0)]

my Terminalmix mappings fail when trying to connect LEDs to ..,show_mixer, show_4decks and other essential skin COs

[Jan Holthuis (holthuis-jan)]

I'm setting this to high. We should make these COs either first-class Mixxx COs that always work, or remove them from all builtin mappings.

At the moment, all mappings that use one of these COs are unusable with skins that donvt support them and won't work in QML mode either.

[Swiftb0y (swiftb0y)]

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/10315