Main asserts in case syntax errors in JavaScript mappings

[Jörg Wartenberg]

For many JavaScript mapping syntax failure, but not for all, Mixxx terminates in an assert:

DEBUG ASSERT: "m_pJSEngine" in function bool __cdecl ControllerScriptEngineLegacy::callFunctionOnObjects(const class QList<class QString> &,const class QString &,const class QList<class QJSValue> &,bool) at ..\..\src\controllers\scripting\l
egacy\controllerscriptenginelegacy.cpp:29

Seen with Main on Windows7

[Daniel Schürmann (daschuer)]

Here is a link to the affected line:

https://github.com/mixxxdj/mixxx/blob/c833006c4c6894b77ea0e4b8c75c89a6d9f7e4d4/src/controllers/scripting/legacy/controllerscriptenginelegacy.cpp#L29

This happens when initialize() is not called before callFunctionOnObjects()

[Daniel Schürmann (daschuer)]

In Mixxx 2.2, we don't have this safety net it would immediately crash. So I am afraid this is a regression that need sti be fixed.

[Daniel Schürmann (daschuer)]

Can you verify if this is the only assertion? There are similar checks Inbthe file.
Which controller script is affected?

[ronso0 (ronso0)]

@Jörg Wartenberg
Is this still present in 2.3 builds?

[Jörg Wartenberg (joerg-ubuntu)]

This is a Main issue, I never saw it on 2.3

[ronso0 (ronso0)]

Can you verify if this is the only assertion? There are similar checks In the file.
Which controller script is affected?

[Jörg Wartenberg (joerg-ubuntu)]

This occured while developing the Z2 mapping in: https://github.com/mixxxdj/mixxx/pull/3038

When the assert occured, there were various typos in the JavaScript code. Without JavaScript syntax failures, as in the PR, Mixxx runs stable without assert.

[Be (be.ing)]

I cannot confirm this on the current main branch. I think it was fixed somewhere along the way. Please reopen this bug if it is still a problem.

[Swiftb0y (swiftb0y)]

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/10291