Tooltip for vinylcontrol_status does not match to skins

[Jörg Wartenberg]

The tooltip describes the colors of the vinylcontrol_status widget as follows:

Vinyl Status
Provides visual feedback for vinyl control status:
Green for control enabled.
Blinking yellow for when the needle reaches the end of the record.
Blue for passthrough enabled.

At least some skins use other visualizations (e.g. in LateNight it blinks green and passthrough is indicated by another widget).

[ronso0 (ronso0)]

IMO make the colors match the tooltip is not worth it, considering how small the indicator is implmented in current skins. Also
* green and blue are not suitable to indicate the distinction between
  enabled and passthrough
* we have a Vinyl Control toggle indicating the Enabled state
* we have more prominent Passthrough indicator:
 - the Passthrough toggle
 - the dimmed overview with the Passthrough label

So IMO the all states are shown adequately.
The End-of-record warning (blinking) could be incorporated into the Vinyl Control toggle, similiar how it's done for the Broadcast and Recording toggles.

What do you think?

[Jörg Wartenberg (joerg-ubuntu)]

> End-of-record warning (blinking) could be incorporated into the Vinyl Control toggle
That would be great!

But whatever is implemented, the tooltip should match to the implementation.

[Daniel Schürmann (daschuer)]

@ronso0 Do you plan still to fix this for 2.3.2?

[ronso0 (ronso0)]

Nope, didn't look at it yet, so it shouldn't hold up 2.3.2
I will wokr on it once I added the effect unit menu buttons to main.

[Swiftb0y (swiftb0y)]

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/10192