DEBUG_ASSERT: Reimport file tags with Serato cues

Bug #1888321 reported by Uwe Klotz
4
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mixxx
New
Low
Jan Holthuis

Bug Description

Debug [Main]: Reading cues from 'Serato Markers2' tag data...
Critical [Main]: DEBUG ASSERT: "!m_pCueInfoImporterPending->isEmpty()" in function void Track::importPendingCueInfosMarkDirtyAndUnlock(QMutexLocker*) at /tmp/mixxx/src/track/track.cpp:996

#5 0x0000000000498cc4 in mixxx_debug_assert(char const*, char const*, int, char const*)
    (assertion=assertion@entry=0xe99ae8 "!m_pCueInfoImporterPending->isEmpty()", file=file@entry=0xe99490 "/tmp/mixxx/src/track/track.cpp", line=line@entry=996, function=function@entry=0xe99aa0 "void Track::importPendingCueInfosMarkDirtyAndUnlock(QMutexLocker*)") at /usr/include/qt5/QtCore/qlogging.h:90
#6 0x00000000004acb78 in mixxx_maybe_debug_assert_return_true(char const*, char const*, int, char const*)
    (function=0xe99aa0 "void Track::importPendingCueInfosMarkDirtyAndUnlock(QMutexLocker*)", line=996, file=0xe99490 "/tmp/mixxx/src/track/track.cpp", assertion=0xe99ae8 "!m_pCueInfoImporterPending->isEmpty()") at /tmp/mixxx/src/util/assert.h:16
#7 Track::importPendingCueInfosMarkDirtyAndUnlock(QMutexLocker*) (this=0x7ffeec12abf0, pLock=0x7fffffffbae0) at /tmp/mixxx/src/track/track.cpp:996
#8 0x00000000006836bb in Track::importCueInfos(std::shared_ptr<mixxx::CueInfoImporter>)
    (this=0x7ffeec12abf0, pCueInfoImporter=std::shared_ptr<mixxx::CueInfoImporter> (use count 2, weak count 0) = {...}) at /tmp/mixxx/src/track/track.cpp:915
#9 0x0000000000683cef in Track::importMetadata(mixxx::TrackMetadata, QDateTime) (this=this@entry=0x7ffeec12abf0, importedMetadata=..., metadataSynchronized=...)
    at /tmp/mixxx/src/track/track.cpp:186
#10 0x0000000000661e37 in SoundSourceProxy::updateTrackFromSource(SoundSourceProxy::ImportTrackMetadataMode)
    (this=this@entry=0x7fffffffc060, importTrackMetadataMode=importTrackMetadataMode@entry=SoundSourceProxy::ImportTrackMetadataMode::Again) at /tmp/mixxx/src/tagging/customtags.h:50
#11 0x0000000000cad96c in (anonymous namespace)::ImportMetadataFromFileTagsTrackPointerOperation::doApply(TrackPointer const&) const (this=<optimized out>, pTrack=...)
    at /usr/include/c++/10/ext/atomicity.h:100
#12 0x0000000000b3a187 in mixxx::TrackPointerOperation::apply(std::shared_ptr<Track> const&) const (pTrack=std::shared_ptr<Track> (use count 33, weak count 1) = {...}, this=<optimized out>)
    at /tmp/mixxx/src/library/trackprocessing.h:89
#13 mixxx::ModalTrackBatchOperationProcessor::doProcessNextTrack(std::shared_ptr<Track> const&) (pTrack=std::shared_ptr<Track> (use count 33, weak count 1) = {...}, this=0x7fffffffc230)
    at /tmp/mixxx/src/library/trackprocessing.cpp:109
#14 mixxx::ModalTrackBatchProcessor::processTracks(QString const&, TrackCollectionManager*, mixxx::ItemIterator<std::shared_ptr<Track> >*)
    (this=this@entry=0x7fffffffc230, progressLabelText=..., pTrackCollectionManager=0x3365af0, pTrackPointerIterator=0x9d948f0) at /tmp/mixxx/src/library/trackprocessing.cpp:57
#15 0x0000000000cb00d4 in WTrackMenu::applyTrackPointerOperation(QString const&, mixxx::TrackPointerOperation const*, mixxx::ModalTrackBatchOperationProcessor::Mode) const
    (this=0x1190a450, progressLabelText=..., pTrackPointerOperation=0x7fffffffc298, operationMode=mixxx::ModalTrackBatchOperationProcessor::Mode::ApplyAndSave)
    at /usr/include/c++/10/bits/unique_ptr.h:420
#16 0x0000000000cb0193 in WTrackMenu::slotImportMetadataFromFileTags() (this=0x1190a450) at /tmp/mixxx/src/widget/wtrackmenu.cpp:907

Tags: metadata
Changed in mixxx:
milestone: none → 2.3.0
assignee: nobody → Jan Holthuis (holthuis-jan)
importance: Undecided → Medium
importance: Medium → Low
Revision history for this message
Uwe Klotz (uklotzde-deactivatedaccount) wrote :

m_pCueInfoImporterPending is empty if the file doesn't contain any Serato cues. Do we need to check for this earlier or replace the VERIFY_OR_DEBUG_ASSERT with a regular if condition?

Revision history for this message
Be (be.ing) wrote :

Is this still an issue?

Changed in mixxx:
milestone: 2.3.0 → none
Revision history for this message
Swiftb0y (swiftb0y) wrote :

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/10057

lock status: Metadata changes locked and limited to project staff
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.