add support for dark mode on macOS

Bug #1887280 reported by Foss-4
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mixxx
Fix Committed
Low
Be

Bug Description

Currently window title bar and settings are in light mode only.

Would be great if Mixxx adapted the macOS system setting to follow user preferences for dark / light mode and when users are using dark mode support showing the window title bar and preferences in dark mode.

Revision history for this message
Be (be.ing) wrote :

I think we have to update the macOS SDK used in the build environment:
https://doc.qt.io/qt-5/macos.html#opting-out-of-macos-behavior-changes

So this is blocked on https://github.com/mixxxdj/mixxx/pull/1974

Be (be.ing)
Changed in mixxx:
importance: Undecided → Low
status: New → Confirmed
milestone: none → 2.4.0
Revision history for this message
ronso0 (ronso0) wrote :

we may simply load a dark palette for the main menubar since -right now- all our skins are rather dark.
See my latest comments in https://mixxx.zulipchat.com/#narrow/stream/109171-development/topic/Getting.20rid.20of.20the.20menu.20bar/near/202829332

Revision history for this message
Foss-4 (foss-4) wrote :

Closing this, dark mode is now supported thanks to the outstanding work @Be put into the macOS build process. Thanks so much - it is highly appreciated.

Revision history for this message
Foss-4 (foss-4) wrote :
Changed in mixxx:
assignee: nobody → Be (be.ing)
milestone: 2.4.0 → 2.3.0
status: Confirmed → Fix Committed
Revision history for this message
ronso0 (ronso0) wrote :

Nice.
Only the tree icons are kinda useless, except the Colors (brush) icon.
Maybe we should remove the gradients and make them all monochrome? That would only affect themes with a pure black background, with any other OS theme it would be fine IMO.

Revision history for this message
Foss-4 (foss-4) wrote :

re-opening. due to issues which were introduced using newer versions of xcode this got reverted and is thus unfixed again.

Changed in mixxx:
status: Fix Committed → New
milestone: 2.3.0 → 2.4.0
Revision history for this message
Foss-4 (foss-4) wrote (last edit ):

And back to fix committed since https://github.com/mixxxdj/mixxx/pull/4225 was merged. Preferences and title bar are also respecting dark mode now.

Changed in mixxx:
status: New → Fix Committed
Revision history for this message
Swiftb0y (swiftb0y) wrote :

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/10044

lock status: Metadata changes locked and limited to project staff
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.