allow to toggle Spinny cover at runtime

Bug #1883362 reported by ronso0
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mixxx
Fix Committed
Low
ronso0

Bug Description

Right now we have 2 Spinny widgets per GUI deck: one with and one without the cover art.
to save ressources and simplify the skins it would be nice to have only one Spinny.

In <Spinny>, we could connectOnValueChanged m_bShowCover to [Skin],show_cover. Then m_bShowCover is updated on demand and not only when the widget initiaded, for example when the user hits the cover toggle in skin settings.

I'd say this could go into 2.3 as bugfix, especially because this would simplify skins and maybe also solves a crash when changing skins.

Tags: skin
Revision history for this message
ronso0 (ronso0) wrote :

I don't know if we should automatically connect m_bShowCover to [Skin],show_cover when <ShowCover> is missing in the widget setup, and that we should respect <Showcover>false, or if we should parse <ShowCoverDynamically>

description: updated
Changed in mixxx:
milestone: none → 2.3.0
ronso0 (ronso0)
Changed in mixxx:
milestone: 2.3.0 → 2.4.0
Be (be.ing)
Changed in mixxx:
importance: Undecided → Low
milestone: 2.4.0 → none
ronso0 (ronso0)
Changed in mixxx:
status: New → In Progress
assignee: nobody → ronso0 (ronso0)
milestone: none → 2.4.0
Revision history for this message
ronso0 (ronso0) wrote :
Changed in mixxx:
status: In Progress → Fix Committed
Revision history for this message
Swiftb0y (swiftb0y) wrote :

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/10015

lock status: Metadata changes locked and limited to project staff
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.