increase BPM tap filter length
Bug #1882776 reported by
ronso0
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Mixxx |
Confirmed
|
Low
|
Unassigned |
Bug Description
Currently the filter sample list is limited to 5.
If we increase that to let's say 16 or more the detected BPM would get much more accurate and hitting cur_pos then would create a somewhat usable beat grid on the pretty quickly.
Code is here:
https:/
Changed in mixxx: | |
status: | New → Confirmed |
tags: | added: easy |
Changed in mixxx: | |
importance: | Undecided → Low |
assignee: | nobody → ronso0 (ronso0) |
Changed in mixxx: | |
milestone: | 2.3.0 → none |
Changed in mixxx: | |
assignee: | ronso0 (ronso0) → nobody |
To post a comment you must log in.
It seems a bit more complicated that I first thought.
The accuracy doesn't improve with a longer filter list, which may be due to the nature of the InterQuartileMean filter.
I think for long filter lists like 8+ we get better results if we divide the time between the first and last tap and divide it by (number of taps)-1, instead of dropping values considered invalid like the IQM does. (assuming the user taps every beat)
So to improve tap results we'd need
* the IQM for like 4-8 taps = suitable if the momentary BPM matter, like for hand-played music)
* a regular mean filter for 8+ taps = close to perfect results for constant music
What do you think?