open cover art view after single-click release

Bug #1844730 reported by ronso0
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mixxx
Fix Released
Low
ronso0

Bug Description

Like the track title and artist widgets, a deck cover art can be dragged to other decks, samplers or somewhere in the library.
Currently the cover art window opens on mouse button PRESS which partially covers the GUI and thereby blocks certain areas for drag moves.

open cover art view not before single-click is released to keep the view clean for drag movements.
Usual longpress timeout should be apllied.

It could also open if the pointer is still above same widget when being released, but that would still/again be the case when when aborting a drag move. Opening the cover art wouldn't be helpful then.

ronso0 (ronso0)
description: updated
ronso0 (ronso0)
Changed in mixxx:
assignee: nobody → ronso0 (ronso0)
milestone: none → 2.3.0
Revision history for this message
ronso0 (ronso0) wrote :

quick solution:
* in mousePressEvent() in wcoverart.cpp
  if (event->button() == Qt::LeftButton) {
    start longpress timer;}
* add mouseReleaseEvent() {
  if (event->button() == Qt::LeftButton && timer not expired yet) {
    stop timer, delete timer;
    open cover art window;}}

Revision history for this message
ronso0 (ronso0) wrote :
Revision history for this message
Daniel Schürmann (daschuer) wrote :

What is the issue you are trying to solve here?

Revision history for this message
ronso0 (ronso0) wrote :

description updated, sorry for not being clear.

Currently the cover art window opens on mouse button PRESS which partially covers the GUI and thereby blocks certain areas for cover art drag moves.

description: updated
Changed in mixxx:
status: New → In Progress
importance: Undecided → Low
status: In Progress → Fix Committed
tags: added: usability
removed: ux
Changed in mixxx:
status: Fix Committed → Fix Released
Revision history for this message
Swiftb0y (swiftb0y) wrote :

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/9746

lock status: Metadata changes locked and limited to project staff
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.