Mixxx

FX1/2 buttons missing Mic unit in Deere (64 samplers)

Bug #1837716 reported by ronso0
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mixxx
Fix Released
Medium
ronso0
Mixxx 2.2.2

Bug Description

reported in https://www.mixxx.org/forums/viewtopic.php?f=8&t=12822

I don't get why the FX buttons are missing in Deere64, because both Deere & Deere64 use the same template Mic units.

Tags: skin
Revision history for this message
ronso0 (ronso0) wrote :

this is cuased by unneeded SizePolicy here https://github.com/mixxxdj/mixxx/blob/master/res/skins/Deere/microphone.xml#L94 and here https://github.com/mixxxdj/mixxx/blob/master/res/skins/Deere/microphone.xml#L111

While looking into this I found that some bugs creeped in skin.xml & skin_settings.xml in both Deere/Deere64, maybe merging of 2.2 into master?

I'll take care of this soonish

Changed in mixxx:
assignee: nobody → ronso0 (ronso0)
importance: Undecided → Medium
milestone: none → 2.2.2
Revision history for this message
ronso0 (ronso0) wrote :

Mic FX fix
https://github.com/mixxxdj/mixxx/pull/2217

fix for diverged skin.xml
https://github.com/mixxxdj/mixxx/pull/2218

Daniel Schürmann (daschuer)
Changed in mixxx:
status: New → Fix Committed
Uwe Klotz (uklotzde-deactivatedaccount)
Changed in mixxx:
status: Fix Committed → Fix Released
Revision history for this message
Swiftb0y (swiftb0y) wrote :

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/9703

lock status: Metadata changes locked and limited to project staff
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.