simplify [Microphone] COs

Bug #1825161 reported by ronso0
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mixxx
Confirmed
Wishlist
Unassigned

Bug Description

let's number the microphone inputs consecutively, like the Aux inputs:
 [Microphone1...4]
this would simplify skin templates as well as scripts setting up and handling mic controls a lot.

I'd use the plural for mic hide/show CO:
 [Microphones],show_microphones
It would also make sense to use
 [Skin],show_inputs or
 [Skin],show_mic_aux

Tags: easy
ronso0 (ronso0)
Changed in mixxx:
importance: Undecided → Wishlist
Revision history for this message
Daniel Schürmann (daschuer) wrote :

It would be quite easy to use [Microphone1] and alias it to [Microphone] do be compatible with legacy skins.

Changed in mixxx:
status: New → Confirmed
Revision history for this message
ronso0 (ronso0) wrote :

Yup, I hoped it would be that easy :)
can you point me to an alias example?

Revision history for this message
Daniel Schürmann (daschuer) wrote :
tags: added: easy
Revision history for this message
Sanskar Bajpai (pawbud) wrote :

I would like to work on this, may I be guided what needs to be done in brief and how can I achieve it? Thanks

Revision history for this message
Daniel Schürmann (daschuer) wrote :

Find the affected COs in the code.
Replace the name with the new name.
Insert aliases for the old names.

See the link above.

Revision history for this message
Sanskar Bajpai (pawbud) wrote :

On it, thanks a lot

Revision history for this message
Sanskar Bajpai (pawbud) wrote :

I am extremely sorry to bother u again, but I really tried to understand what am trying to achieve, but I simply can't. so, my doubts are:-
1. U said "Find the affected CO's in the code", so do I have to go through the whole list of controllers https://github.com/mixxxdj/mixxx/wiki/Mixxxcontrols or is it that I have to work only with the Microphone Controllers? https://github.com/mixxxdj/mixxx/wiki/Mixxxcontrols/49407737fa36c55d4570597803c7ed362a344309#microphonen

2. How Do I recognize the ones that are affected (or perhaps it is because I didn't understand the issue)

3.https://github.com/mixxxdj/mixxx/blob/9da873a777a147a3afadfb3a988ec42112359d1e/src/effects/effectrack.cpp#L431 here intellisense said `Adds a ConfigKey for 'alias' to the control for 'key'. Can be used for
supporting a legacy / deprecated control. The 'key' control must exist
for this to work.` Not sure what's confusing about it.

4.In the bug Description by ronso0 he asks about numbering the microphone's input like the aux inputs, moreover [Microphones],show_microphones, [Skin],show_inputs or, [Skin],show_mic_aux are to replace the controllers in the codebase, right? if so I can't really find the controllers which will be replaced by the above mentioned names(like what will show_mic_aux replace?).

Once again sorry for the trouble, I just wanted to clearly understand what is it I am working on.

Revision history for this message
Sanskar Bajpai (pawbud) wrote :

Update: Ok, Ok I think that I understood it, I was thinking that CO stands for controls, but instead its controller objects and now everything makes sense :)

Revision history for this message
Swiftb0y (swiftb0y) wrote :

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/9633

lock status: Metadata changes locked and limited to project staff
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.