Maximize Library steals focus, makes keyboard presses non-working

[jus]

Tested 2.3.0-alpha-pre (build master r6723)
macOS 10.14.2 (18C54)

Skins affected: Deere, Tango

* Start Mixxx in developer mode
* Load a affected skin
* Load a track to deck 1
* Maximize library, either pressing SPACE bar, or using the dedicated button
* Press the button D to start/stop the track in deck 1

Expected behavior:
* start/stop the track in deck 1
* Log entry : Debug [Main]: keyboard press: "D"

Actual behavior:
* None, the library lost focus. Press TAB key to re-set focus, then pressing D (or any other defined keyboard action) works again.

related:
lp:1259040 Clicking on deck controls affects library keyboard focus
lp:1673196 Controls for Library focus

[ronso0 (ronso0)]

The issue is that the we need normal & the maximized libary as two different occurences of a library singleton in Deere & Tango, due to the stacked waveforms that can be hidden/moved.
I tried a few things earlier but couldn't solve this issue from within the skins.

I think of a CO that tracks the library table/tree focus state. This would be helpful also for situations where you clicked on waveforms (library unfocused) and quickly want to use the Trax knob again.

I there a way to emit a signal when widgets pseudo state changes to 'focus'?

related: https://bugs.launchpad.net/mixxx/+bug/1673196

[ronso0 (ronso0)]

btw the keyboard shortcuts also work again when I click into any overview widget.
maybe it's just that no widget has focus after toggling the swapping the library singletons?

[ronso0 (ronso0)]

If I'm not missing something I think skin.xml of Deere and Tango could both use a WidgetStack to toggle maximized Library, like it works in LateNight. There, the focus jumps to the Sidebar and back to the tracks table when repeatedly toggling [Master],maximize_library, but the shortcuts still work

[ronso0 (ronso0)]

https://github.com/mixxxdj/mixxx/pull/2289

[ronso0 (ronso0)]

https://github.com/mixxxdj/mixxx/pull/2289 is ready for review.

Testing is very welcome, especially Win and macOS

[Swiftb0y (swiftb0y)]

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/9586