store selected table item index when switching library features

Bug #1808472 reported by ronso0
30
This bug affects 5 people
Affects Status Importance Assigned to Milestone
Mixxx
Fix Committed
High
ronso0

Bug Description

scenario:
* listen to tracks from Tracks view
* find a track that inspires you to start a new playlist
* right-click any other library feature like Playlists or Crates
 (for example to create or rename a playlist/crate)*
= tracks table switches to respective library feature
(damn! lp:1810810)
* go back to Tracks
= table shows correcct scroll position
* use [Library],ScrollVertical,+-1
= scroll position jumps to top of the list

master (2.3) 2018-12-14

ronso0 (ronso0)
description: updated
Revision history for this message
Daniel Schürmann (daschuer) wrote :

I cannot confirm this with the current master using mouse.
After creating a new carte and than clicking back on the Track tree icon, the scrol bar search and highlighting are back.
Any idea what else can I do to reproduce the issue.

Revision history for this message
ronso0 (ronso0) wrote :

hmm the main issue here seems to be that my mouse makes the current not-yet-focused table view jump ~20 lines up as soon as I use the mouse scroll wheel; I noticed this behaviour in other apps, as well.

The second issue is that the track selection is gone (while the scroll position is kept) when I focus the table again via controller or Tab key. If I press Up/Down keys or scroll with controller encoder, the first track is selected which makes the scroll position jump to the top.

I think I'll split this one into multiple bugs.
The tracks table losing focus when I just want to rename (not view) a playlist/crate or create a new on is annoying, because I'll have to scroll up in tree view to get back to Tracks, for example.

ronso0 (ronso0)
description: updated
Revision history for this message
ronso0 (ronso0) wrote :

I updated the report, it now just describes the scroll position jump when using a controller.

The other aspect of this is in lp:1810810

ronso0 (ronso0)
description: updated
ronso0 (ronso0)
summary: - library: keep table view when right-clicking any other feature
+ keep table scroll position when switching library features
Revision history for this message
Daniel Schürmann (daschuer) wrote : Re: keep table scroll position when switching library features

I can confirm this. I t happens also if you use the up and down keys on keyboard.

Changed in mixxx:
status: New → Confirmed
importance: Undecided → High
Revision history for this message
ronso0 (ronso0) wrote :

the reason seems to be that the first table cell is somehow focused and the selection jumps there when keys or selection controls attempt to move it.

noticed with https://bugs.launchpad.net/mixxx/+bug/1808632
" can't focus tracks table item if there is only one "

I'm trying to save/restore also the selection focus it when re-activating a library view.
this wouldn work if multiple rows are selected, but I guess that's okay.

ronso0 (ronso0)
summary: - keep table scroll position when switching library features
+ store selected table item index when switching library features
ronso0 (ronso0)
Changed in mixxx:
assignee: nobody → ronso0 (ronso0)
status: Confirmed → In Progress
ronso0 (ronso0)
tags: added: library usability
Revision history for this message
Daniel Schürmann (daschuer) wrote :

It this fixed now or in progress by one of the related PRs?

Revision history for this message
ronso0 (ronso0) wrote :
Changed in mixxx:
status: In Progress → Confirmed
Revision history for this message
ronso0 (ronso0) wrote :
Changed in mixxx:
status: Confirmed → In Progress
assignee: ronso0 (ronso0) → poelzi (launchpad-net-poelzi)
milestone: none → 2.3.0
ronso0 (ronso0)
Changed in mixxx:
milestone: 2.3.0 → 2.3.1
Revision history for this message
ronso0 (ronso0) wrote :

PR with library selection commits of #3063
https://github.com/mixxxdj/mixxx/pull/4177

Changed in mixxx:
milestone: 2.3.1 → 2.4.0
Be (be.ing)
Changed in mixxx:
assignee: poelzi (launchpad-net-poelzi) → ronso0 (ronso0)
ronso0 (ronso0)
Changed in mixxx:
status: In Progress → Fix Committed
Revision history for this message
Swiftb0y (swiftb0y) wrote :

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/9547

lock status: Metadata changes locked and limited to project staff
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.