macOS: mixxx leaves fullscreen view when switching skins

[Foss-4]

macOS 10.13.5
mixxx-2.2.0-alpha-pre-master-git6517-release-macintel64.dmg

Reproducible: always

Currently

Switch skins and you'll find yourself in window mode

Expected

stay in fullscreen mode

[Benis (beenisss)]

Also on macOS, 10.13.6, and I've seen the same thing both in the official release and building directly from source. The default size is pretty small too.

I've noticed Mixxx resets the window size if you switch skins while not full-screen too, though obviously it's particularly inelegant if you are in full-screen mode at the time.

Additionally, if you quit from full screen, Mixxx reopens with the window at maximum size, but not in a screen of its own. I don't think macOS lets applications open straight to a screen of their own, so all this really does is overwrite the user-determined window size for non-full screen mode. I think the default/recommended behaviour is to always open in a non-maximized window. That's what Safari does at least, which seems a pretty good indicator.

Hope I've explained that properly.

[Benis (beenisss)]

When I build the current 2.3.0 alpha-pre it handles this properly. Not sure if that's because it's been fixed or just a quirk of my system, it seems to have a few.

[ronso0 (ronso0)]

on Linux it fails with 2.3 as well but differently:
Mixxx stays fullscreen, but the new skin is loaded with window mode size.
Remaining space (at the right & at the bottom stil shows the framebuffer from the previous skin. Resizing, or toggling fullscreen twice paints the skin correctly.

[Uwe Klotz (uklotzde-deactivatedaccount)]

2.2 + XWayland + Full-screen view: Ok
You can watch the repainting while switching skins, but eventually the new skin fills the whole window/screen. I don't need to toggle full-screen view again.

2.2 + XWayland + Window view: (Ok)
The application window is resized to minimum size when switching skins. But I don't consider this a bug, just a minor glitch.

[JosepMa (josepma)]

Windows 10: Mixxx 2.2 built from sources this weekend. Things works as expected as in:

When in fullscreen and switching skins, it temporarily switches to windowed mode, and when the skin is loaded it goes back into fullscreen.

Could it be that this "switching on/off" of the fullscreen mode causes it to not enter fullscreen in some circumstances?

What I've observed in the other bug at #1773587 is that when used in maximized state it does what is reported here. But maximized is not the same as fullscreen.

[Benis (beenisss)]

I said this in an earlier comment:

> When I build the current 2.3.0 alpha-pre it handles this properly. Not sure if that's because it's been fixed or just a quirk of my system, it seems to have a few.

I suspect I mis-stated the case. I currently get the issue with all builds and releases.

The only thing different is that the official release doesn't restore to a maximized window properly, whereas the beta and any build from a recent master do.

[Benis (beenisss)]

I don't think this is the same issue as #1773587

[Daniel Schürmann (daschuer)]

Ups .. Thank you.

[Foss-4 (foss-4)]

Is this issue on the radar for 2.2.1 indeed? Is there a PR already? Is there a dev willing to work on this?

[ronso0 (ronso0)]

btw: skins are also shown at minimal size after (re)loading skins in windowed mode although Mixxx fills the screen.

[ronso0 (ronso0)]

another observation (ubuntu studio, X11):
window with custom size > maximize = maximized window
window maximized > F11 = fullscreen
fullscreen > F11 = window with custom size

window with custom size > reload skin = window at minimal size (set by skin)

some hopefully helpful input before I work on it myself:
https://stackoverflow.com/questions/38182367/how-to-toggle-a-window-from-fullscreen-to-normal-mode-programmatically#38182513

maybe we should do this when reloading the main window:
* if fullscreen: leave fullscreen, restore minimal size (un-maximize)
* if maximized: restore minimal size (un-maximize), store maximize state
(* not fullscreen, not maximized: store window size (as it does now))
X reload skin
(should be at normal size now)
* enter fullscreen mode or restore maximize state

[Foss-4 (foss-4)]

This problem is unchanged. Is anybody willing to look into this? Seems like various OS are affected. Functionality is not decreased but it's somewhat annoying to have windows jump around and switch size by themselves.

[Daniel Schürmann (daschuer)]

I can confirm this.
Unfortunately no one had found time to look into it yet.

[Daniel Schürmann (daschuer)]

This was fixed here
https://github.com/mixxxdj/mixxx/pull/2690

[Foss-4 (foss-4)]

Sorry, not fixed on macOS. Still leaving full-screen when switching skin.
macOS 10.15.4
mixxx 2.3.0-alpha-pre (build master r7331)

[ronso0 (ronso0)]

okay, open for MacOS.
Fixed for Linux in https://github.com/mixxxdj/mixxx/pull/2690

[Foss-4 (foss-4)]

yup, original report was filed against macOS so let's leave this bug open.

[ronso0 (ronso0)]

@foss-4 Is the issue still in 2.3?

[Foss-4 (foss-4)]

unchanged and persisting

[ronso0 (ronso0)]

maybe fixed by
https://github.com/mixxxdj/mixxx/pull/3859

[Foss-4 (foss-4)]

Goes back to window mode after skin switch testing 2.3-beta-3983-g674fc8ceee (HEAD branch) (from this PR) on macOS 11.3.1.

Oh and thanks very much for looking into this. ❤️

[Foss-4 (foss-4)]

Setting to wontfix as per https://github.com/mixxxdj/mixxx/pull/3859 investigation showing there is no way to address this problem.

Maybe qt6 will behave as expected.

[Swiftb0y (swiftb0y)]

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/9343