Comment 0 for bug 1774790

Revision history for this message
Uwe Klotz (uklotzde-deactivatedaccount) wrote : Mixxx may crash when reading TagLib ID3v2 frames

Mixxx may crash when reading TagLib ID3v2 frame when their runtime type differs from the compile time expectations, e.g. when an APIC frame is actually not a TagLib::ID3v2::AttachedPictureFrame.

Reported in the forums:
https://www.mixxx.org/forums/viewtopic.php?f=3&t=11872&p=38590#p38585

Solution:
We need to use a dynamic_cast at runtime instead of a static_cast at compile time to identify the actual type of a frame and prevent crashes caused by corrupt or malformed files.