Mixxx may crash when importing TagLib ID3v2 APIC frames
Bug #1774790 reported by
Uwe Klotz
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Mixxx |
Fix Released
|
Critical
|
Unassigned | ||
Bug Description
Mixxx may crash when reading TagLib ID3v2 APIC frames if their runtime type differs from the compile time expectations, e.g. when an APIC frame is actually not a TagLib:
Reported in the forums:
https:/
Solution:
We need to use a dynamic_cast at runtime instead of a static_cast at compile time to identify the actual type of a frame and prevent crashes caused by corrupt or malformed files.
| Changed in mixxx: | |
| assignee: | nobody → Uwe Klotz (uklotzde) |
Revision history for this message
| Uwe Klotz (uklotzde-deactivatedaccount) wrote | #1 |
| summary: |
- Mixxx may crash when reading TagLib ID3v2 frames + Mixxx may crash when importing TagLib ID3v2 frames |
| summary: |
- Mixxx may crash when importing TagLib ID3v2 frames + Mixxx may crash when importing TagLib ID3v2 APIC frames |
| description: | updated |
| Changed in mixxx: | |
| status: | In Progress → Fix Committed |
| Changed in mixxx: | |
| status: | Fix Committed → Fix Released |
Revision history for this message
| Swiftb0y (swiftb0y) wrote | #2 |
| lock status: | Metadata changes locked and limited to project staff |
To post a comment you must log in.
https:/