"Next" and "Previous" don't save changes to track metadata

Bug #1774625 reported by Jesse French
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Mixxx
Confirmed
Wishlist
Unassigned

Bug Description

When editing track metadata in Mixxx library, hitting "Next" and "Previous" buttons should save the track metadata before moving to edit the next track. Instead, I have to hit "Apply" every time, before moving to the next track.

Ubuntu 16.04 LTS
Mixxx 2.1.0 x64

Revision history for this message
Uwe Klotz (uklotzde-deactivatedaccount) wrote :

I also always stumble about this. On the other hand saving metadata implicitly while navigating is dangerous.

Maybe add a checkbox for enabling implicit saving during an editing session? This setting should be visible directly in the dialog and not buried deep in the preferences. It needs to be re-enabled once the dialog has been closed.

Changed in mixxx:
status: New → Confirmed
importance: Undecided → Wishlist
Revision history for this message
Be (be.ing) wrote :

I think it would be better to ask the user when the next/previous buttons are pressed than bury the option in the preferences (why would a user think to look there when editing metadata?).

Revision history for this message
Uwe Klotz (uklotzde-deactivatedaccount) wrote :

I don't propose a preference setting, that context would be too broad.

Confirming a dialog box each time after pressing Next/Previous is also inconvenient when editing multiple items in a row. Maybe the checkbox can be integrated into this confirmation dialog to enable the implicit "Apply" action for all subsequent Next/Previous interactions until the properties dialog is closed.

Revision history for this message
Daniel Schürmann (daschuer) wrote :

The current layout implies to me, that I can edit as many tracks I like and finally press cancel or apply all. So we should either do it exact like that and keep a list of cloned tracks, or we need to rearrange the buttons like this draft:

[Apply and Previous] [Apply and Next] [Apply and Close] [Restore] [Cancel]

or

------- Apply Changes ----- ------- Reject Changes -----
[Previous] [Next] [Close] [Restore] [Cancel]

Revision history for this message
Jesse French (jfrench) wrote : Re: [Bug 1774625] Re: "Next" and "Previous" don't save changes to track metadata

Interesting...having been a Mac user for many years, in iTunes it's
standard behavior that clicking "Next" or "Previous" saves the changes. I
don't quite understand the logic of making changes to metadata, then moving
to another track and it NOT saving. Why would anyone want to do that?

On Fri, Jun 1, 2018 at 7:51 AM, Daniel Schürmann <<email address hidden>
> wrote:

> The current layout implies to me, that I can edit as many tracks I like
> and finally press cancel or apply all. So we should either do it exact
> like that and keep a list of cloned tracks, or we need to rearrange the
> buttons like this draft:
>
> [Apply and Previous] [Apply and Next] [Apply and Close] [Restore]
> [Cancel]
>
> or
>
> ------- Apply Changes ----- ------- Reject Changes -----
> [Previous] [Next] [Close] [Restore] [Cancel]
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1774625
>
> Title:
> "Next" and "Previous" don't save changes to track metadata
>
> Status in Mixxx:
> Confirmed
>
> Bug description:
> When editing track metadata in Mixxx library, hitting "Next" and
> "Previous" buttons should save the track metadata before moving to
> edit the next track. Instead, I have to hit "Apply" every time, before
> moving to the next track.
>
> Ubuntu 16.04 LTS
> Mixxx 2.1.0 x64
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/mixxx/+bug/1774625/+subscriptions
>

Revision history for this message
Daniel Schürmann (daschuer) wrote :

The user might have messed up things and want to undo it. We should at least keep an option for this.

Revision history for this message
Jesse French (jfrench) wrote :

But that's why you can click "cancel." If you navigate off the screen with
"ok / apply" or "next / previous," it should save unless you tell it
otherwise IMO.

On Tue, Jun 5, 2018, 2:10 PM Daniel Schürmann <email address hidden>
wrote:

> The user might have messed up things and want to undo it. We should at
> least keep an option for this.
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1774625
>
> Title:
> "Next" and "Previous" don't save changes to track metadata
>
> Status in Mixxx:
> Confirmed
>
> Bug description:
> When editing track metadata in Mixxx library, hitting "Next" and
> "Previous" buttons should save the track metadata before moving to
> edit the next track. Instead, I have to hit "Apply" every time, before
> moving to the next track.
>
> Ubuntu 16.04 LTS
> Mixxx 2.1.0 x64
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/mixxx/+bug/1774625/+subscriptions
>

Revision history for this message
Swiftb0y (swiftb0y) wrote :

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/9323

lock status: Metadata changes locked and limited to project staff
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.