Mixxx

Qt5: BIg Samplers are broken in Shade

Bug #1773588 reported by Daniel Schürmann
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mixxx
Fix Released
Medium
Daniel Schürmann
Mixxx 2.1.2

Bug Description

See screenshot.

Revision history for this message
Daniel Schürmann (daschuer) wrote :
Revision history for this message
Daniel Schürmann (daschuer) wrote :

This was tested with Ubuntu Xenial and QT 5.5

Confirmed in https://mixxx.zulipchat.com/#narrow/stream/109122-general/subject/QT5.20build.20Master/near/127138224

Changed in mixxx:
status: New → Confirmed
milestone: none → 2.2.0
Revision history for this message
ronso0 (ronso0) wrote :

I'd say it's due to unnecessary QWidget { margin: 0px; padding: 10px; } in sampler.xml:line6
Appearantly this has no effect in qt4 but is respected and rendered in qt5.
If this line is removed there's no difference with qt4. Please test with qt5.
I'd open a PR but I can't compile master with qt5 reliably right now.

Revision history for this message
ronso0 (ronso0) wrote :

https://github.com/mixxxdj/mixxx/blob/master/res/skins/Shade/sampler.xml#L6

Revision history for this message
Daniel Schürmann (daschuer) wrote :

Ah yes, Thank you.
Fixed in
https://github.com/mixxxdj/mixxx/pull/1759

Changed in mixxx:
milestone: 2.2.0 → 2.1.2
status: Confirmed → In Progress
importance: Undecided → Medium
assignee: nobody → Daniel Schürmann (daschuer)
ronso0 (ronso0)
Changed in mixxx:
status: In Progress → Fix Committed
Daniel Schürmann (daschuer)
Changed in mixxx:
status: Fix Committed → Fix Released
Revision history for this message
Swiftb0y (swiftb0y) wrote :

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/9310

lock status: Metadata changes locked and limited to project staff
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Bug attachments

Remote bug watches

Bug watches keep track of this bug in other bug trackers.