[Library] MoveVertical and Focus when Mixxx windows is not focused

Bug #1771611 reported by Dale on 2018-05-16
This bug affects 1 person
Affects Status Importance Assigned to Milestone

Bug Description

When using [Library] MoveVertical it only works if the Mixxx window is the one that has focus (main application window, not sub-panes.)

Using additional software alongside standard DJing although maybe not entirely the norm is one of the more basic ways to expand your DJ set. This may be having sampler software with a drum kit of a soft synth to play keys over sections of your performance, for just some basic examples (or more advanced incorporating Mixxx in a true live set if your material is lacking enough for a full set.)

Strangely checking the terminal when launched with --controllerDebug shows it as considering the command to be an Up/Down key press when Mixxx is in focus, but to be a Tab key press when it is not (although it doesn't change which pane has focus like pressing Tab would do.)

So can we please have this MIDI control work no matter what application window is in focus by the operating system. It works for all other controls. I'm hoping it may be related to a Global Focus and be fixable by the addition of a Library Focus, which could also fix my comment on the bug below.


Semi-related bug:

It would definitely improve things with that if there was a separate Library Focus that was restricted to the Library panes, so clicking on a control you don't have on your controller (probably a very common occurrence for some) would not lose your focus for library navigation, requiring you to click in the Library pane again or press Tab twice to return to it.

description: updated
ronso0 (ronso0) wrote :

The [Library]..MoveVertical is sending emulated key presses to the sidebar or trackstable, depending on what has focus. The Tab key in the log is sent by setLibraryFocus() in librarycontrol.cpp to re-focus the tracks table whenever a Track select knob is turned while another widget has focus.

There are also the [Playlist] controls that don't need the affected widget to be focused:

At least [Playlist],SelectTrackKnob works with unfocused Mixxx window.
Maybe we can improve [Playlist],SelectPlaylist to work this way, as well.

ronso0 (ronso0) wrote :

It seems [PLaylist],SelectPlaylist is broken:

Warning [Controller]: ControlDoublePrivate::getControl returning NULL for ( "[PLaylist]" , "SelectPlaylist" )

ronso0 (ronso0) wrote :

Partially fixed by https://github.com/mixxxdj/mixxx/pull/2307
"keep the library focused when any deck controls or the overview are clicked"

summary: - [Library] MoveVertical and Focus
+ [Library] MoveVertical and Focus when Mixxx windows is not focused
ronso0 (ronso0) on 2020-05-29
Changed in mixxx:
status: New → Confirmed
importance: Undecided → Low
assignee: nobody → ronso0 (ronso0)
milestone: none → 2.3.0
tags: added: controllers library
ronso0 (ronso0) on 2020-08-28
Changed in mixxx:
assignee: ronso0 (ronso0) → nobody
ronso0 (ronso0) on 2020-10-14
Changed in mixxx:
milestone: 2.3.0 → 2.4.0
assignee: nobody → ronso0 (ronso0)
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers