Cue controls' play status should not change during scratching

[Sean M. Pappalardo]

In the 2.1 branch, Cue controls act like the deck is stopped during scratching, making it possible to set/move the main cue point accidentally. While of course the deck motion technically is stopped, the fact that it's still in play status should be respected by the cue COs.

To reproduce:
1) Set Cue mode in Deck preferences to Mixxx mode (for consistency)
2) Load a track
3) Click Play. Deck plays.
4) "Grab" the track, either with the left mouse button or by touching a controller wheel so the play motion stops
5) Notice that the CUE indicator in the GUI (and on the controller) flashes, meaning a cue point can be set.
6) Release the deck, notice that the CUE indicator goes off.

When repeating the above using the right mouse button (scrub,) the CUE indicator works as expected.

[Waylon Robertson (wrobertson1981)]

isn't this how dj's cue up a track on cdj's, playing a track, then bringing it back to the first beat, scratching at it, then putting the cue down?

[Sean M. Pappalardo (pegasus-renegadetech)]

Sure, but they usually pause before setting the cue, so it can be precisely where they want it. (CDJs repeatedly play the CD frame selected when in pause mode so you can hear exactly where you're setting the cue.)

[Waylon Robertson (wrobertson1981)]

Confirmed: https://www.youtube.com/watch?v=VyK-qAQzCGI
Interesting! Might have to put in a feature request.

What i don't get from this, is how does one stop the track, without the frame preview?

[Swiftb0y (swiftb0y)]

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/9291