Deere skin has no Sample gain knob

Bug #1763953 reported by Daniel Schürmann
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Mixxx
Medium
Uwe Klotz

Bug Description

I think our default skin should have such a knob.

Discovered here:
https://www.mixxx.org/forums/viewtopic.php?f=6&t=11707

Revision history for this message
Peter Burg (wunjo) wrote :

It is my preferred skin and I can't use it now

Changed in mixxx:
status: New → Confirmed
importance: Undecided → Medium
Revision history for this message
Daniel Schürmann (daschuer) wrote :

Do you have interest to look into this yourself?

I think you need to edit this file:
https://github.com/mixxxdj/mixxx/blob/12da5a54eedba3376ea2186dcb4cf01d4e1a6b8a/res/skins/Deere/sampler_controls_row.xml

and add something like

<Template src="skin:mixer_column_gain_levels.xml"/>

or the content of mixer_column_gain_levels.xml

tags: added: easy
Revision history for this message
Uwe Klotz (uklotzde) wrote :
Revision history for this message
Uwe Klotz (uklotzde) wrote :
Revision history for this message
Uwe Klotz (uklotzde) wrote :

I've added a gain knob to the top row, just a hack. This would be my preferred solution.

Revision history for this message
Be (be.ing) wrote :

I would not like the gain knob cluttering the simple sampler view, but it could be added to the expanded view. As a workaround, you could also apply gain to your samples in Audacity or a DAW so you don't need to keep adjusting the gain knob in Mixxx.

Revision history for this message
Peter Burg (wunjo) wrote :

@ Uwe
Thanks for the xml!
Don't know much about coding, so where does I have to place this piece to make it work? Just for personal use I don't matter much for cluttering to make it work.
@ Be
I understand your style concerns. Using a DAW isn't exactly flexible.

Revision history for this message
Peter Burg (wunjo) wrote :

In the expanded view is my preferred option.

Revision history for this message
Uwe Klotz (uklotzde) wrote :
Changed in mixxx:
milestone: none → 2.1.1
assignee: nobody → Uwe Klotz (uklotzde)
status: Confirmed → In Progress
Revision history for this message
Peter Burg (wunjo) wrote :

Thanks for the link, will check it on my PC

Be (be.ing)
Changed in mixxx:
status: In Progress → Won't Fix
status: Won't Fix → Fix Committed
Changed in mixxx:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers