star rating widget does not scale with skin

Bug #1751290 reported by ronso0
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mixxx
Won't Fix
Low
Unassigned

Bug Description

1. button icons (Play button and a few toggles):
if they are defined with background shorthand property
 background: #color url(skin:...) no-repeat center;

with separate properties for bg and icon it works.

2. Effect parameter knobs
margin isn't scaled, in stacked layout it becomes obvious

3. Star rating widget
scaling is applied to widget but not to star size

EDIT
Actually, this affects all skins. It appears, none of the pixel sizes/distances set in stylesheet.qss are scaled: border, border-image, margin, padding

Tags: skin
ronso0 (ronso0)
Changed in mixxx:
assignee: nobody → ronso0 (medontknow)
tags: added: skin
ronso0 (ronso0)
description: updated
summary: - button icons don't get scaled properly In Tango
+ HiDPi scaling issues in Tango
Be (be.ing)
Changed in mixxx:
status: New → Confirmed
milestone: none → 2.1.0
ronso0 (ronso0)
summary: - HiDPi scaling issues in Tango
+ HiDPi scaling issues
description: updated
Revision history for this message
ronso0 (ronso0) wrote : Re: HiDPi scaling issues

changed the bug title since this affects all skins

description: updated
Revision history for this message
Be (be.ing) wrote :

Is this still an issue for 2.1?

Revision history for this message
ronso0 (ronso0) wrote :

This is not fixed, I just worked around 1. (button icons) and 2. (margin issue) in https://github.com/mixxxdj/mixxx/pull/1531. I didn't find a solution for the star rating.

The issues below are still there, of course:
> Actually, this affects all skins. It appears, none of the pixel
> sizes/distances set in stylesheet.qss are scaled:
> border, border-image, margin, padding

Be (be.ing)
summary: - HiDPi scaling issues
+ stars in star rating widget do not scale
summary: - stars in star rating widget do not scale
+ stars in star rating widget do not scale with skin
Changed in mixxx:
assignee: ronso0 (medontknow) → Be (be.ing)
importance: Undecided → Medium
Revision history for this message
Be (be.ing) wrote : Re: stars in star rating widget do not scale with skin

I can reproduce the issue with the star rating widget. I think the other issues will be solved when switching to Qt5.

Be (be.ing)
summary: - stars in star rating widget do not scale with skin
+ star rating widget does not scale with skin
Revision history for this message
Be (be.ing) wrote :

I didn't get around to doing this for 2.1 and this is hardly a release blocker. It won't be relevant anymore after we switch to Qt5, so I am marking this as Won't Fix.

Changed in mixxx:
assignee: Be (be.ing) → nobody
status: Confirmed → Won't Fix
importance: Medium → Low
Revision history for this message
Swiftb0y (swiftb0y) wrote :

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/9150

lock status: Metadata changes locked and limited to project staff
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.