Metronome effect on a paused track

[Kshitij Gupta]

The metronome effect when applied to a playing deck, continues to tick if the track is paused just on the beat. Otherwise, it stops with the track.

A consistent behaviour must be followed.

[Be (be.ing)]

I am not certain that the effect should only play when the deck is playing. Consider someone playing a live instrument along with a track. They may want to hear the metronome at the tempo of the next track for a few bars before starting the new track.

Perhaps the effect should have a volume knob that is linked to the metaknob by default.

[Kshitij Gupta (kshitij98)]

I also believe that if the metronome can also be played even when the deck is not playing gives more control to the user. As otherwise if he wants to stop the metronome, he can turn it off.

[Kshitij Gupta (kshitij98)]

https://github.com/mixxxdj/mixxx/pull/1541

I have opened a pull request fixing this issue. The metronome effect is now working as per the group features passed and it stops as soon as the beat_fraction stops increasing.

After this commit, the metronome will stop showing an arbitrary behavior when the effect rack is in MASTER mode. Since the passed master features do not have a beat fraction, it will not tick at all.

Maintaining a beat_fraction for the master track seems to be a solution to this and the bug mentioned in https://bugs.launchpad.net/mixxx/+bug/1738590

Please review

[Swiftb0y (swiftb0y)]

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/9144