Error dialog not displayed
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Mixxx |
Fix Released
|
Low
|
RJ Skerry-Ryan | ||
Bug Description
Discovered while discussing https:/
Error dialogs are not handled properly, and might be displayed or not depending on which thread was the first to request an error.
How to reproduce :
Launch mixxx, go to preference -> Live Broadcasting
Check "Turn on Live broadcasting when applying these settings", set encoding format to OggVorbis, rate to 96Kbps and apply.
An error is displayed, as this specific combination of format and rate is not supported
Close mixxx, mess with a controller preset xml file (res > controllers > *.midi.xml), then repeat the steps above. No error is displayed, log shows : "Warning [Controller]: WARNING: errorDialog not called in the main thread. Not showing error dialog."
The reason is that in the second case, the first error called (bad XML) is from a background thread. Any subsequent attempt to display an error dialog will then be made from that thread, even if the error happens in the main thread, as with the broadcasting error.
This is not critical right now because error dialogs are not used widely, and it shouldn't affect users, but might lead to inconsistencies in the future
| RJ Skerry-Ryan (rryan) wrote | #1 |
| tags: | added: broadcast |
| Changed in mixxx: | |
| status: | New → Confirmed |
| importance: | Undecided → Low |
| tags: |
added: easy removed: broadcast |
| Changed in mixxx: | |
| assignee: | nobody → RJ Skerry-Ryan (rryan) |
| status: | Confirmed → In Progress |
| RJ Skerry-Ryan (rryan) wrote | #2 |
| Changed in mixxx: | |
| status: | In Progress → Fix Committed |
| milestone: | none → 2.2.0 |
| Changed in mixxx: | |
| status: | Fix Committed → Fix Released |
| Swiftb0y (swiftb0y) wrote | #3 |
| lock status: | Metadata changes locked and limited to project staff |
Nice catch!