mixxx 2.1 beta, skin Deere, SKIN ERROR invalid TooltipId

[Stefan]

I tested current mixxx 2.1 branch and found some SKIN ERROR in Skin Deere.

Warning [Main]: src/skin/legacyskinparser.cpp:1948 SKIN ERROR at skin:left_display_2state_button.xml:14 <PushButton>: Invalid <TooltipId> in skin.xml: "cueset"

These are the CUE Button in the Samplers Deck.
(Line 80: https://github.com/mixxxdj/mixxx/blob/2.1/res/skins/Deere/sampler_controls_row.xml)

Currently there is no Tooltip showed on this button!

It doesn't act as a "hot cue" Button so we could not add the
<TooltipId>hotcue</TooltipId>

It doesn't act as "cue" Button so we could not add the
<TooltipId>cue_default_cue_gotoandstop</TooltipId>

So either the functionality has to be changed or an additional Tooltip
"cueset" has to be added..

Possible solution with adding "cueset" tooltip:

in https://github.com/mixxxdj/mixxx/commits/2.1/src/skin/tooltips.cpp:

+ // Currently used for decks (deere only)
+
+ add("cueset")
+ << tr("set Cue")
+ << QString("%1: %2").arg(leftClick, cueSet);

Alternative Solution, change it to "hotcue" or "cue_default_cue_gotoandstop" button functionality (might be more useful)

[Stefan (nopeppermint)]

fix: https://github.com/mixxxdj/mixxx/pull/1471

[Stefan (nopeppermint)]

sorry wrong bug, on this I have open Questions !

[ronso0 (ronso0)]

Jup, that tooltip is missing.
Let's just take the CO description string for translations from there:
https://www.mixxx.org/wiki/doku.php/mixxxcontrols#channeln > "cue_set"

PR should be targeted at mixxx/2.2 aka mixxx/master because it changes a string used for translations.

[jus (jus)]

https://github.com/mixxxdj/mixxx/pull/1500/commits/d119889a2d45ae970c19e7e3e16f3a728c0b7754

[Be (be.ing)]

https://github.com/mixxxdj/mixxx/pull/1500

[Swiftb0y (swiftb0y)]

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/9057